Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task]: Modify locales on AMO #15433

Closed
2 tasks
abyrne-moz opened this issue Mar 10, 2025 · 7 comments
Closed
2 tasks

[Task]: Modify locales on AMO #15433

abyrne-moz opened this issue Mar 10, 2025 · 7 comments
Assignees
Labels
qa:verified_fix repository:addons-frontend Issue relating to addons-frontend repository:addons-server Issue relating to addons-server
Milestone

Comments

@abyrne-moz
Copy link

abyrne-moz commented Mar 10, 2025

Description

The following locales are below threshold of 40% or completely absent in one of our projects in Pontoon and need to be disabled:

  • Afrikaans [af]
  • Asturian [ast]
  • Azerbaijani [az]
  • Basque [eu]
  • Bengali [bn]
  • Bosnian [bs]
  • Catalan [ca]
  • Estonian [et]
  • Gujarati (India) [gu-IN]
  • Gujarati [gu]
  • Hindi (India) [hi-IN]
  • Irish [ga-IE]
  • Latvian [lv]
  • Lithuanian [lt]
  • Macedonian [mk]
  • Maltese [mt]
  • Mongolian [mn]
  • Persian [fa]
  • Sinhala [si]
  • Urdu [ur]
  • Welsh [cy]

The following locales are above threshold and need to be enabled:

  • Friulian [fur]
  • Icelandic [is]
  • Interlingua [ia]

Acceptance Criteria

Milestones/checkpoints

Preview Give feedback

Checks

  • If I have identified that the work is specific to a repository, I have removed "repository:addons-server" or "repository:addons-frontend"

┆Issue is synchronized with this Jira Task

@abyrne-moz abyrne-moz added needs:info repository:addons-server Issue relating to addons-server repository:addons-frontend Issue relating to addons-frontend labels Mar 10, 2025
@abyrne-moz abyrne-moz changed the title [Task]: Disable below threshold locales on AMO [Task]: Modify locales on AMO Mar 10, 2025
@diox
Copy link
Member

diox commented Mar 10, 2025

Note that both addons-frontend (config/default.js, see langs) and addons-server (src/olympia/core/languages.py, see AMO_LANGUAGES) need to be updated. In some cases the 2 weren't previously in sync, but they should be once this is done.

@diox diox self-assigned this Mar 11, 2025
@abyrne-moz
Copy link
Author

Is it worth me logging a new ticket to get these locale codes added to our notification email?

@diox
Copy link
Member

diox commented Mar 11, 2025

I fixed the email to add the locales codes in the PR, it hasn't been merged yet.

I also fixed a bug which would lead a locale that was only present in one project and above the threshold to be added to the list we want to enable - found when looking at Hindi: it should not have been in the list, given that we don't have translations for the frontend at all in that locale.

@diox
Copy link
Member

diox commented Mar 12, 2025

FWIW, if we were to make the threshold 70% right away, as of today this would also remove the following (on top of the list above that we are removing from production next week because they are below 40%):

  • Bulgarian [bg]
  • Danish [da]
  • Finnish [fi]
  • Kaqchikel [cak]
  • Malay [ms]
  • Norwegian (Bokmål) [nb-NO]
  • Sinhala [si]
  • Telugu [te]

In addition, we would keep the following but they are below 70% so this is a concern:

  • Arabic [ar] (kept because it's a RTL language and we want at least a couple to ensure AMO works in RTL)
  • Polish [pl]
  • Spanish (Spain) [es-ES]

@diox
Copy link
Member

diox commented Mar 12, 2025

If we were to make the threshold 80% right away, as of today this would also remove the following (on top of the list above that we are removing from production next week because they are below 40%):

  • Bulgarian [bg]
  • Danish [da]
  • Finnish [fi]
  • Icelandic [is]
  • Indonesian [id]
  • Kaqchikel [cak]
  • Malay [ms]
  • Norwegian (Bokmål) [nb-NO]
  • Norwegian (Nynorsk) [nn-NO]
  • Punjabi (India) [pa-IN]
  • Romanian [ro]
  • Sinhala [si]
  • Telugu [te]
  • Thai [th]

In addition, we would keep the following but they are below 80% so this is a concern:

  • Arabic [ar]
  • Japanese [ja]
  • Polish [pl]
  • Spanish (Spain) [es-ES]

@ioanarusiczki
Copy link

ioanarusiczki commented Mar 12, 2025

On frontend it looks good. -> languages removed would redirect to https://addons-dev.allizom.org/en-US/firefox/

In dev hub or rev tools I've a 404 with the languages removed. Example https://addons-dev.allizom.org/en-US/firefox/mn/developers/

@diox
Copy link
Member

diox commented Mar 12, 2025

That's acceptable for /developers/ - it's not a new problem, and the previous pages were likely broken to some degree anyway due to the bad completion rate of translations in the old locale.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified_fix repository:addons-frontend Issue relating to addons-frontend repository:addons-server Issue relating to addons-server
Projects
None yet
Development

No branches or pull requests

4 participants