[Bug]: Holding a rejection for 2nd level approval does not clear the existing pending rejection

[ialecse]

What happened?

Promoted add-on:

• version is delayed rejected with build issues
• developer replies, uploads a new source code and the build issue is fixed and the review process continues
• version is rejected due to policy violations
• instant rejection is being hold for 2nd level approval
• the previous delayed rejection expires and the add-on get auto rejected for build issues
• instant rejection is approved and the add-on gets rejected again

What did you expect to happen?

If a promoted add-on has a pending rejection and another negative action is issued, the pending rejection should either be cleared or paused until the new negative action is approved/deny

Is there an existing issue for this?

• I have searched the existing issues

┆Issue is synchronized with this Jira Task

[eviljeff]

@ialecse I'm confused by some parts of the STR:

version is delayed rejected with build issues

this would have also been held for 2nd level approval though, and must have been cleared for rejection. So why is it surprising it's then rejected?

developer replies, uploads a new source code and the build issue is fixed and the review process continues

wouldn't the reviewer have cleared the pending rejection at this point?

[ialecse]

this would have also been held for 2nd level approval though, and must have been cleared for rejection. So why is it surprising it's then rejected?

because it shouldn't have been rejected with the reason from the delayed rejection, as an instant rejection, with a different message, was issued

wouldn't the reviewer have cleared the pending rejection at this point?

Reviewers only clear pending rejections if they issue a new one, otherwise it is not necessary and not in the process. When an instant rejection is issued it's assumed that the previous pending rejection is cleared. This is exactly what happens with non-promoted add-ons, but when the instant rejection is hold for approval the pending rejection is still active and therefore the add-on ends up being rejected for 2 complete separate issues.