Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot pass General Tests to upload add-on because it contains ES modules and class fields #3960

Closed
sineway opened this issue Oct 11, 2021 · 4 comments · Fixed by #3984
Closed

Cannot pass General Tests to upload add-on because it contains ES modules and class fields #3960

sineway opened this issue Oct 11, 2021 · 4 comments · Fixed by #3984
Assignees
@willdurand
Labels
priority:p3 state:verified_fixed type:syntax Issues related to JavaScript syntax (support).
Milestone
2021.11.18

Comments

@sineway
Copy link

sineway commented Oct 11, 2021

The are multiple files, but all with the same «symptoms»

JavaScript syntax error (Parsing as module error: Unexpected token = at line: 8 and column: 16) (Parsing as script error: 'import' and 'export' may appear only with 'sourceType: module' at line: 4 and column: 1)

Source file
@sineway sineway closed this as completed Oct 12, 2021
@willdurand willdurand mentioned this issue Oct 12, 2021
Closed
@willdurand
Copy link
Member

The issue makes sense here. Let's reopen it 😁

@willdurand willdurand reopened this Oct 12, 2021
@willdurand
Copy link
Member

I think this issue is somehow related to this one: #3062, this is a known limitation but the good news is that ESLint v8 is out and it should now support public field declarations.

@sineway
Copy link
Author

sineway commented Oct 12, 2021

Ok, thanks

@willdurand willdurand self-assigned this Nov 2, 2021
@willdurand willdurand added type:syntax Issues related to JavaScript syntax (support). priority:p3 labels Nov 2, 2021
@willdurand willdurand mentioned this issue Nov 2, 2021
Merged
3 tasks
@willdurand willdurand added this to the 2021.11.11 milestone Nov 3, 2021
@ioanarusiczki
Copy link

@willdurand
The JavaScript syntax error is no longer present with linter 4.0.0 or on AMO dev.

now:
dev

before:
stage

timeunit.zip

@bobsilverberg bobsilverberg modified the milestones: 2021.11.11, 2021.11.18 Nov 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@willdurand willdurand

Labels
priority:p3 state:verified_fixed type:syntax Issues related to JavaScript syntax (support).
Projects
None yet
Milestone
2021.11.18
Development

Successfully merging a pull request may close this issue.

Upgrade ESLint to v8 mozilla/addons-linter
4 participants
@bobsilverberg @willdurand @sineway @ioanarusiczki