Removed tests relating to latest version, updated tests relating to older versions

Author: chrstinalin

tests/unit/amo/pages/TestAddonVersions.js

@@ -10,21 +10,16 @@ import {
   ADDON_TYPE_STATIC_THEME,
   CLIENT_APP_ANDROID,
   CLIENT_APP_FIREFOX,
-  FATAL_ERROR,
   INCOMPATIBLE_ANDROID_UNSUPPORTED,
   INCOMPATIBLE_FIREFOX_FOR_IOS,
   INCOMPATIBLE_NOT_FIREFOX,
-  INCOMPATIBLE_OVER_MAX_VERSION,
   INCOMPATIBLE_UNDER_MIN_VERSION,
-  INCOMPATIBLE_UNSUPPORTED_PLATFORM,
-  INSTALLING,
   STRATEGIC,
   VERIFIED,
 } from 'amo/constants';
 import { extractId } from 'amo/pages/AddonVersions';
 import { formatFilesize } from 'amo/i18n/utils';
 import { FETCH_ADDON, fetchAddon, loadAddon } from 'amo/reducers/addons';
-import { setInstallError, setInstallState } from 'amo/reducers/installations';
 import { getPromotedBadgesLinkUrl } from 'amo/utils';
 import {
   correctedLocationForPlatform,
@@ -645,104 +640,11 @@ describe(__filename, () => {
       ).toBeInTheDocument();
     });
 
-    const setupInstallError = () => {
-      const guid = 'some-guid';
-      const addon = { ...fakeAddon, guid, slug: defaultSlug };
-      store.dispatch(setInstallState({ guid, status: INSTALLING }));
-      store.dispatch(setInstallError({ error: FATAL_ERROR, guid }));
-      _loadAddon(addon);
-    };
-
-    it('passes an install error to AddonInstallError', () => {
-      setupInstallError();
-      _loadVersions();
-      render();
-
-      expect(
-        within(screen.getByClassName('AddonInstallError')).getByText(
-          'An unexpected error occurred.',
-        ),
-      ).toBeInTheDocument();
-    });
-
-    it('does not render an install error if there is no error', () => {
-      renderWithAddonAndVersions();
-      render();
-
-      expect(
-        screen.queryByClassName('AddonInstallError'),
-      ).not.toBeInTheDocument();
-    });
-
-    it('does not render an AddonInstallError if there is no version', () => {
-      setupInstallError();
-      _loadVersions({ versions: [] });
-      render();
-
-      expect(
-        screen.queryByClassName('AddonInstallError'),
-      ).not.toBeInTheDocument();
-    });
-
-    it('does not render an AddonInstallError if it is not the current version', () => {
-      setupInstallError();
-      _loadVersions({
-        versions: [fakeVersion, { ...fakeVersion, id: 2 }],
-      });
-      render();
-
-      const versionCards = allVersionCards();
-      expect(
-        within(versionCards[0]).getByText('An unexpected error occurred.'),
-      ).toBeInTheDocument();
-      expect(
-        within(versionCards[1]).queryByText('An unexpected error occurred.'),
-      ).not.toBeInTheDocument();
-    });
-
-    it('does not render an AddonCompatibilityError if there is no version', () => {
-      getClientCompatibility.mockReturnValue(
-        createFakeClientCompatibility({
-          compatible: false,
-          reason: INCOMPATIBLE_OVER_MAX_VERSION,
-        }),
-      );
-      renderWithAddonAndVersions({ versions: [] });
-
-      expect(
-        screen.queryByClassName('AddonCompatibilityError'),
-      ).not.toBeInTheDocument();
-    });
-
-    it('does not render an AddonCompatibilityError if it is not the current version', () => {
-      getClientCompatibility.mockReturnValue(
-        createFakeClientCompatibility({
-          compatible: false,
-          reason: INCOMPATIBLE_OVER_MAX_VERSION,
-        }),
-      );
-      renderWithAddonAndVersions({
-        versions: [fakeVersion, { ...fakeVersion, id: 2 }],
-      });
-
-      const versionCards = allVersionCards();
-      expect(
-        within(versionCards[0]).getByText(
-          'This add-on is not compatible with your version of Firefox.',
-        ),
-      ).toBeInTheDocument();
-      expect(
-        within(versionCards[1]).queryByText(
-          'This add-on is not compatible with your version of Firefox.',
-        ),
-      ).not.toBeInTheDocument();
-    });
-
     it('passes an add-on to InstallButtonWrapper', () => {
       renderWithAddonAndVersions();
 
       expect(
-        screen.getByRole('link', { name: 'Add to Firefox' }),
+        screen.getByRole('link', { name: 'Download file' }),
       ).toHaveAttribute('href', fakeVersion.file.url);
     });
 
@@ -763,7 +665,7 @@ describe(__filename, () => {
       const versionCards = allVersionCards();
       expect(versionCards).toHaveLength(2);
       expect(
-        within(versionCards[0]).getByRole('link', { name: 'Add to Firefox' }),
+        within(versionCards[0]).getByRole('link', { name: 'Download file' }),
       ).toBeInTheDocument();
       expect(
         within(versionCards[1]).getByRole('link', { name: 'Download file' }),
@@ -849,39 +751,6 @@ describe(__filename, () => {
       ).not.toBeInTheDocument();
     });
 
-    it('renders a notice if add-on is over maxVersion/compat is strict', () => {
-      getClientCompatibility.mockReturnValue(
-        createFakeClientCompatibility({
-          compatible: false,
-          reason: INCOMPATIBLE_OVER_MAX_VERSION,
-        }),
-      );
-      renderWithAddonAndVersions();
-
-      expect(
-        screen.getByClassName('AddonCompatibilityError'),
-      ).toBeInTheDocument();
-      expect(
-        screen.getByText(
-          'This add-on is not compatible with your version of Firefox.',
-        ),
-      ).toBeInTheDocument();
-    });
-
-    it('renders a notice if add-on is incompatible with the platform', () => {
-      getClientCompatibility.mockReturnValue(
-        createFakeClientCompatibility({
-          compatible: false,
-          reason: INCOMPATIBLE_UNSUPPORTED_PLATFORM,
-        }),
-      );
-      renderWithAddonAndVersions();
-
-      expect(
-        screen.getByText('This add-on is not available on your platform.'),
-      ).toBeInTheDocument();
-    });
-
     it.each([
       INCOMPATIBLE_ANDROID_UNSUPPORTED,
       INCOMPATIBLE_FIREFOX_FOR_IOS,