Skip to content
This repository was archived by the owner on Apr 17, 2021. It is now read-only.

codecov/patch still failing #778

Closed
mcomella opened this issue Apr 5, 2018 · 2 comments
Closed

codecov/patch still failing #778

mcomella opened this issue Apr 5, 2018 · 2 comments
Assignees
@nojunpark

Comments

@mcomella
Copy link
Contributor

mcomella commented Apr 5, 2018

screenshot-2018-4-5 closes 756 pause resume timers by bkmunar pull request 760 mozilla-mobile firefox-tv from #760.

@npark-mozilla Do you know what's up?
@nojunpark
Copy link
Contributor

Codecov is saying that the diff between the patch and master (i.e. the changes) is not covered by unit tests at all. It seems For now, we can disable the check on patch, and only monitor for the % drop on the project.

@nojunpark nojunpark mentioned this issue Apr 5, 2018
Merged
@mcomella
Copy link
Contributor Author

mcomella commented Jul 3, 2018

Seems fixed by #779.

@mcomella mcomella closed this as completed Jul 3, 2018
@alexmt alexmt mentioned this issue Jul 11, 2019
Merged
@mogren mogren mentioned this issue Sep 22, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@nojunpark nojunpark

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mcomella @nojunpark