Skip to content

Commit a19590e

Browse files
mergify[bot]PARAIPAN9
andauthoredJan 13, 2025
Bugfix FXIOS-11009 - [Toolbar Redesign] One tap new tab doesn't open a new tab when custom homepage url is set (backport #24056) (#24058)
Bugfix FXIOS-11009 - [Toolbar Redesign] One tap new tab doesn't open a new tab when custom homepage url is set (#24056) Open new tab when custom url is set. (cherry picked from commit 548c1af) Co-authored-by: PARAIPAN SORIN <51127880+PARAIPAN9@users.noreply.github.com>
1 parent b536f3f commit a19590e

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed
 

‎firefox-ios/Client/Frontend/Browser/BrowserViewController/Views/BrowserViewController.swift

+1
Original file line numberDiff line numberDiff line change
@@ -4099,6 +4099,7 @@ extension BrowserViewController: TopTabsDelegate {
40994099
let homePageURL = HomeButtonHomePageAccessors.getHomePage(profile.prefs)
41004100

41014101
if shouldLoadCustomHomePage, let url = homePageURL {
4102+
openBlankNewTab(focusLocationField: false, isPrivate: isPrivate)
41024103
tabManager.selectedTab?.loadRequest(PrivilegedRequest(url: url) as URLRequest)
41034104
} else {
41044105
openBlankNewTab(focusLocationField: true, isPrivate: isPrivate)

‎firefox-ios/Client/Frontend/Browser/PrivilegedRequest.swift

+1-1
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ private let REQUEST_KEY_PRIVILEGED = "privileged"
2525
PrivilegedRequest(), but the value of doing this is not clear as these requests should work fine
2626
as regular URLRequest().
2727
**/
28-
class PrivilegedRequest: NSMutableURLRequest {
28+
final class PrivilegedRequest: NSMutableURLRequest {
2929
override init(url: URL, cachePolicy: NSURLRequest.CachePolicy, timeoutInterval: TimeInterval) {
3030
func getUrl() -> URL {
3131
if InternalURL.isValid(url: url), let result = InternalURL.authorize(url: url) {

0 commit comments

Comments
 (0)