Skip to content

Commit 6aa0c91

Browse files
authored
Refactor FXIOS-5658 [v112] Update localized string from Sites to Pages (#13207)
* refact: Update string from Sites to Pages * refact: Change version to v112 * reafact: Adjust testConfigureGroupCell()
1 parent 6279bbb commit 6aa0c91

File tree

4 files changed

+13
-6
lines changed

4 files changed

+13
-6
lines changed

.swiftpm/xcode/package.xcworkspace/contents.xcworkspacedata

+7
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Client/Frontend/Browser/Tabs/ASGroup.swift

+1-1
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ extension ASGroup: HighlightItem {
3434
}
3535

3636
var description: String? {
37-
return String.localizedStringWithFormat(.FirefoxHomepage.Common.SitesCount, groupedItems.count)
37+
return String.localizedStringWithFormat(.FirefoxHomepage.Common.PagesCount, groupedItems.count)
3838
}
3939

4040
var siteUrl: URL? {

Client/Frontend/Strings.swift

+4-4
Original file line numberDiff line numberDiff line change
@@ -179,11 +179,11 @@ extension String {
179179
/// Identifiers of all new strings should begin with `FirefoxHome.`
180180
public struct FirefoxHomepage {
181181
public struct Common {
182-
public static let SitesCount = MZLocalizedString(
183-
"FirefoxHomepage.Common.SitesCount.v101",
182+
public static let PagesCount = MZLocalizedString(
183+
"FirefoxHomepage.Common.PagesCount.v112",
184184
tableName: nil,
185-
value: "Sites: %d",
186-
comment: "Label showing how many sites there is in a search group. %d represents a number")
185+
value: "Pages: %d",
186+
comment: "Label showing how many pages there is in a search group. %d represents a number")
187187
}
188188

189189
public struct CustomizeHomepage {

Tests/ClientTests/Frontend/Home/HistoryHighlights/HistoryHighlightsViewModelTests.swift

+1-1
Original file line numberDiff line numberDiff line change
@@ -211,7 +211,7 @@ class HistoryHighlightsViewModelTests: XCTestCase {
211211
XCTAssertNotNil(cell)
212212
XCTAssertFalse(cell!.isFillerCell)
213213
XCTAssertEqual(cell!.itemDescription.text,
214-
String.localizedStringWithFormat(.FirefoxHomepage.Common.SitesCount, 2))
214+
String.localizedStringWithFormat(.FirefoxHomepage.Common.PagesCount, 2))
215215
}
216216

217217
func testDidSelectItem() {

0 commit comments

Comments
 (0)