Remove FXIOS-10865 [Dead code] Clean up dead code (#23703)

* Further clean up with periphery

* remove comment

* Remove dead telemetry

Author: lmarceau

.periphery.yml

@@ -0,0 +1,16 @@
+project: firefox-ios/Client.xcodeproj
+schemes:
+- Fennec
+targets:
+- Account
+- AccountTests
+- Client
+- ClientTests
+- NotificationService
+- SharedTests
+- Storage
+- StorageTests
+- Sync
+- SyncTelemetryTests
+- UITests
+- XCUITests

firefox-ios/Client.xcodeproj/project.pbxproj

@@ -18,7 +18,6 @@ class AccessoryViewProvider: UIView, Themeable, InjectedThemeUUIDIdentifiable {
         static let fixedSpacerHeight: CGFloat = 30
         static let fixedLeadingSpacerWidth: CGFloat = 2
         static let fixedTrailingSpacerWidth: CGFloat = 3
-        static let doneButtonFontSize: CGFloat = 17
     }
 
     // MARK: - Properties

firefox-ios/Client/AccessoryViewProvider.swift

@@ -12,7 +12,7 @@ import Foundation
 /// main element wherein they appear. As we continue updating views, all
 /// `.accessibilityIdentifier` identifiers from the client and the tests
 /// should be move here and updated throughout the app.
-public struct AccessibilityIdentifiers {
+struct AccessibilityIdentifiers {
     /// Used for toolbar/URL bar buttons since our classes are built that buttons can live in one or the other
     /// Using only those a11y identifiers for both ensures we have standard way to refer to buttons from iPad to iPhone
     struct Toolbar {

firefox-ios/Client/Application/AccessibilityIdentifiers.swift

@@ -4,8 +4,6 @@
 
 import UIKit
 import Shared
-import Storage
-import Sync
 import UserNotifications
 import Account
 

firefox-ios/Client/Application/AppDelegate+PushNotifications.swift

@@ -3,10 +3,7 @@
 // file, You can obtain one at http://mozilla.org/MPL/2.0/
 
 import Shared
-import Storage
-import Sync
 import UserNotifications
-import Account
 import Common
 
 extension UIApplication {
@@ -22,16 +19,13 @@ extension UIApplication {
 /// they can be handled when the app performs a sync.
 class AppFxACommandsDelegate: FxACommandsDelegate {
     private let app: ApplicationStateProvider
-    private let logger: Logger
     private var applicationHelper: ApplicationHelper
     private var mainQueue: DispatchQueueInterface
 
     init(app: ApplicationStateProvider,
-         logger: Logger = DefaultLogger.shared,
          applicationHelper: ApplicationHelper = DefaultApplicationHelper(),
          mainQueue: DispatchQueueInterface = DispatchQueue.main) {
         self.app = app
-        self.logger = logger
         self.applicationHelper = applicationHelper
         self.mainQueue = mainQueue
     }

firefox-ios/Client/Application/AppDelegate+SyncSentTabs.swift

@@ -3,7 +3,6 @@
 // file, You can obtain one at http://mozilla.org/MPL/2.0/
 
 import Shared
-import Storage
 import CoreSpotlight
 import UIKit
 import Common

firefox-ios/Client/Application/AppDelegate.swift

@@ -14,12 +14,6 @@ enum ShortcutType: String {
     case openLastBookmark = "OpenLastBookmark"
     case qrCode = "QRCode"
 
-    init?(fullType: String) {
-        guard let last = fullType.components(separatedBy: ".").last else { return nil }
-
-        self.init(rawValue: last)
-    }
-
     var type: String {
         return Bundle.main.bundleIdentifier! + ".\(self.rawValue)"
     }
@@ -35,12 +29,6 @@ struct QuickActionInfos {
 
 // MARK: - QuickActions
 protocol QuickActions {
-    func addDynamicApplicationShortcutItemOfType(
-        _ type: ShortcutType,
-        fromShareItem shareItem: ShareItem,
-        toApplication application: UIApplication
-    )
-
     func addDynamicApplicationShortcutItemOfType(
         _ type: ShortcutType,
         withUserData userData: [String: String],
@@ -64,25 +52,7 @@ extension QuickActions {
 }
 
 struct QuickActionsImplementation: QuickActions {
-    private let logger: Logger
-
-    init(logger: Logger = DefaultLogger.shared) {
-        self.logger = logger
-    }
-
     // MARK: Administering Quick Actions
-    func addDynamicApplicationShortcutItemOfType(_ type: ShortcutType,
-                                                 fromShareItem shareItem: ShareItem,
-                                                 toApplication application: UIApplication) {
-        var userData = [QuickActionInfos.tabURLKey: shareItem.url]
-        if let title = shareItem.title {
-            userData[QuickActionInfos.tabTitleKey] = title
-        }
-        addDynamicApplicationShortcutItemOfType(type,
-                                                withUserData: userData,
-                                                toApplication: application)
-    }
-
     func addDynamicApplicationShortcutItemOfType(
         _ type: ShortcutType,
         withUserData userData: [String: String] = [String: String](),

firefox-ios/Client/Application/QuickActions.swift

@@ -5,7 +5,6 @@
 import UIKit
 import CoreSpotlight
 import Shared
-import Sync
 import UserNotifications
 import Common
 

firefox-ios/Client/Application/SceneDelegate.swift

@@ -23,15 +23,15 @@ class UserConversionMetrics {
         self.userDefaults = userDefaults
     }
 
-    public func didStartNewSession() {
+    func didStartNewSession() {
         guard shouldRecordMetric() else { return }
         appOpenTimestamps.append(Date())
         if shouldActivateProfile() {
             sendActivationEvent()
         }
     }
 
-    public func didPerformSearch() {
+    func didPerformSearch() {
         guard shouldRecordMetric() else { return }
         searchesTimestamps.append(Date())
         if shouldActivateProfile() {

firefox-ios/Client/Application/UserConversionMetrics.swift

@@ -7,7 +7,7 @@ import Foundation
 // Only push the task async if we are not already on the main thread.
 // Unless you want another event to fire before your work happens.
 // This is better than using DispatchQueue.main.async to ensure main thread
-public func ensureMainThread(execute work: @escaping @convention(block) () -> Swift.Void) {
+func ensureMainThread(execute work: @escaping @convention(block) () -> Swift.Void) {
     if Thread.isMainThread {
         work()
     } else {
@@ -17,7 +17,7 @@ public func ensureMainThread(execute work: @escaping @convention(block) () -> Sw
     }
 }
 
-public func ensureMainThread<T>(execute work: @escaping () -> T) {
+func ensureMainThread<T>(execute work: @escaping () -> T) {
     if Thread.isMainThread {
         _ = work()
     } else {

firefox-ios/Client/DispatchQueueHelper.swift

@@ -134,7 +134,7 @@ enum Experiments {
     }
 
     /// The `NimbusApi` object. This is the entry point to do anything with the Nimbus SDK on device.
-    public static var shared: NimbusInterface = {
+    static var shared: NimbusInterface = {
         let defaults = UserDefaults.standard
         let isFirstRun: Bool = defaults.object(forKey: NIMBUS_IS_FIRST_RUN_KEY) == nil
         if isFirstRun {
@@ -223,7 +223,7 @@ enum Experiments {
     /// - Parameters:
     ///     - fireURL: an optional file URL that stores the initial experiments document.
     ///     - firstRun: a flag indicating that this is the first time that the app has been run.
-    public static func intialize() {
+    static func intialize() {
         // Getting the singleton first time initializes it.
         let nimbus = Experiments.shared
 

firefox-ios/Client/Experiments/Experiments.swift

@@ -31,7 +31,7 @@ struct GleanPlumbMessage {
     ///
     /// This is corresponds to a MessageKey string from Nimbus.
     ///
-    public let id: String
+    let id: String
 
     /// The underlying MessageData from Nimbus.
     ///

firefox-ios/Client/Experiments/Messaging/GleanPlumbMessage.swift

@@ -14,6 +14,10 @@ protocol RemoteTabsPanelDelegate: AnyObject {
     func presentFxAccountSettings()
 }
 
+protocol RemoteTabsClientAndTabsDataSourceDelegate: AnyObject {
+    func remoteTabsClientAndTabsDataSourceDidSelectURL(_ url: URL, visitType: VisitType)
+}
+
 class RemoteTabsPanel: UIViewController,
                        Themeable,
                        RemoteTabsClientAndTabsDataSourceDelegate,