Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(NODE-6613): Update error messages when primaries go stale #4397

Merged
merged 8 commits into from
Feb 7, 2025

Conversation

W-A-James
Copy link
Contributor

@W-A-James W-A-James commented Feb 4, 2025

Description

What is changing?

Update error messages added to ServerDescription objects to more accurately reflect Topology state when Primaries step down.

Is there new documentation needed for these changes?

None

What is the motivation for this change?

NODE-6613, DRIVERS-2972

Release Highlight

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@W-A-James W-A-James changed the title fix(NODE-6613): Update tests and messages fix(NODE-6613): Update error messages when primaries go stale Feb 4, 2025
@W-A-James W-A-James marked this pull request as ready for review February 4, 2025 22:44
@W-A-James W-A-James requested a review from a team as a code owner February 4, 2025 22:44
@nbbeeken nbbeeken self-assigned this Feb 5, 2025
@nbbeeken nbbeeken added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Feb 5, 2025
@W-A-James W-A-James requested a review from nbbeeken February 6, 2025 21:09
@nbbeeken nbbeeken merged commit 6528c8d into main Feb 7, 2025
26 of 30 checks passed
@nbbeeken nbbeeken deleted the NODE-6613/fully-implement-spec branch February 7, 2025 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Primary Review In Review with primary reviewer, not yet ready for team's eyes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants