fix(NODE-4936)!: remove unsupported options from db.command and admin.command

[nbbeeken]

Description

What is changing?

• Removes unsupported options from db.command and admin.command

Internal:

• Changes the inheritance of Run, Admin, Rename, CommandOperations classes
  • This fixes the accidental support of more options than should be supported
• Unskip test for RC option in runCommand
• Changes the construction of AdminCommand, unnecessary params
• MongoClient close uses executeOperation b/c of the public options not supporting noResponse

Is there new documentation needed for these changes?

What is the motivation for this change?

Spec compliance

Release Highlight

db.command() and admin.command() unsupported options removed

These APIs allow for specifying a command BSON document directly, so the driver does not try to enumerate all possible commands that could be passed to this API in an effort to be as forward and backward compatible as possible. Supporting various server-side options that are encoded into the command document is difficult to correctly support for all use cases.

The db.command() and admin.command() APIs have their options types updated to accurately support options compatible on all commands that could be passed to either API. Perhaps most notably, readConcern and writeConcern options are no longer handled by the driver, users must attach these properties to the command that is passed to the .command() method.

Double check the following

• Ran npm run check:lint script
• Self-review completed using the steps outlined here
• PR title follows the correct format: type(NODE-xxxx)[!]: description
  • Example: feat(NODE-1234)!: rewriting everything in coffeescript
• Changes are covered by tests
• New TODOs have a related JIRA ticket
• Fill out release hightlight

[baileympearson]

We're missing the following test from the kickoff:

Add WC not supported test to match the RC one. (The spec tests that RC/WC is not inherited from db/client, we supported it as a direct option)

[baileympearson]

removed because this no longer exists?

[nbbeeken]

Kinda, the xx! properties on this class are tech debt from the rapid TS conversion, we couldn't sort out which subclasses actually defined these and which didn't. Specifically cmd what only being attached by the RenameOperation so we don't need it defined on this super class. But also Rename is somewhat special in that most of our commands are build in the exec function, not in the constructor, so even Rename doesn't define this property anymore.

[baileympearson]

Suggested change

	override options: RunCommandOptions;
	command: Document;
	constructor(parent: OperationParent | undefined, command: Document, options?: RunCommandOptions) {
	super(parent, options);
	this.options = options ?? {};
	constructor(parent: Db, command: Document, options: RunCommandOptions) {
	super(options);
	this.options = options;
	this.command = command;
	this.ns = parent.s.namespace.withCollection('$cmd');
	}
	constructor(parent: Db, public command: Document, public override options: RunCommandOptions) {
	super(options);
	this.ns = parent.s.namespace.withCollection('$cmd');
	}

optional

[nbbeeken]

done