Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: Change the default target view of contact request notifications #1114

Closed
2 tasks done
lissine0 opened this issue Jul 20, 2024 · 4 comments
Closed
2 tasks done

Comments

@lissine0
Copy link
Member

Precondition

  • I understood that this template is only for feature requests and not for bug reports

Cross-checked related issues?

Describe your feature

Monal's contact request iOS notifications have "approve new contact" and "deny new contact" actions, but you need to long click the notification to see them.
There's also an iOS-builtin "open" action. (which is the default if you simply click the notification from within the app)
Currently, choosing this action takes you to the contact's chat view, without accepting nor rejecting their request.
Shouldn't it take you to the Contact Requests view?

@lissine0
Copy link
Member Author

Video illustration of clicking the notification from within the app:

1114.mp4

@tmolitor-stud-tu
Copy link
Member

Well, that was intentional to allow users to chat with this person without having to answer the contact request (yet).
The new chat view will show a floating warning that this contact has an open contact request.

That said, the contact requests view has a button to open a chat without accepting or rejecting the request, too. So opening the contact requests view would be a possible option, too.

What do you think is better (taking in account the planned floating warning)?

@lissine0
Copy link
Member Author

I think it makes more sense to take you to the contact requests view. That's more natural, especially since we have a proper view for contact requests.

It's still possible to chat without answering the contact request by

  • clicking the button that does so in the contact requests view
  • accessing the chat directly from the Chats view, assuming you or your potential contact already sent a message to the other

The planned floating warning will still be beneficial, as it'll remind the user to add the other person to their roster, so they can have a better experience (A/V calls, presence etc.)

@tmolitor-stud-tu
Copy link
Member

okay, thanks for your insights :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants