Test fail on 31/12

[guimard]

Describe the bug

The test fail on 31/12. Here is a simple patch:

--- a/test/datetime/relative.test.js
+++ b/test/datetime/relative.test.js
@@ -121,7 +121,9 @@
 test("DateTime#toRelativeCalendar picks the correct unit with no options", () => {
   const now = DateTime.now();
   const isLastDayOfMonth = now.endOf("month").day === now.day;
+  const isLastDayOfYear = now.endOf("year").day === now.day;
   expect(now.plus({ days: 1 }).toRelativeCalendar()).toBe(
+    isLastDayOfYear ? "next year" :
     isLastDayOfMonth ? "next month" : "tomorrow"
   );
 });

Reported by Debian: https://bugs.debian.org/109810

[vpzomtrrfrt]

the referenced debian bug predates the existence of luxon by over a decade

[diesieben07]

Thank you for the report. You are right, tests that depend on the current time of day are not great.

I don't agree with your patch though, the test should be split up into four tests, which test that this behavior works correctly on all combinations of "last day of the month: yes/no" and "last day of the year: yes/no".