Skip to content

Commit 9d9019c

Browse files
committed
Remove logging shutdown
1 parent ba192db commit 9d9019c

File tree

4 files changed

+2
-15
lines changed

4 files changed

+2
-15
lines changed

samplesheet_validator/samplesheet_validator.py

+1-2
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
import re
1515
from typing import Union
1616
from . import config
17-
from .ss_logger import SSLogger, shutdown_logs
17+
from .ss_logger import SSLogger
1818
from seglh_naming.sample import Sample
1919
from seglh_naming.samplesheet import Samplesheet
2020

@@ -155,7 +155,6 @@ def ss_checks(self) -> None:
155155
self.check_pannos(sample, column, sample_obj)
156156
self.check_tso()
157157
self.log_summary()
158-
shutdown_logs(self.logger)
159158

160159
def check_ss_present(self) -> Union[bool, None]:
161160
"""

samplesheet_validator/ss_logger.py

-11
Original file line numberDiff line numberDiff line change
@@ -22,17 +22,6 @@ def set_root_logger():
2222
logger.addHandler(stream_handler)
2323

2424

25-
def shutdown_logs(logger: object) -> None:
26-
"""
27-
To prevent duplicate filehandlers and system handlers close
28-
and remove all handlers for a logging object
29-
:return (None):
30-
"""
31-
for handler in logger.handlers[:]:
32-
logger.removeHandler(handler)
33-
handler.close()
34-
35-
3625
class SSLogger:
3726
"""
3827
Creates a python logging object with a file handler and syslog handler

setup.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
name="samplesheet_validator",
66
version=git_tag(),
77
description="Python library for samplesheet validation",
8-
url="http://github.com/moka-guys/samplesheet_validator",
8+
url="https://github.com/moka-guys/samplesheet_validator/tree/feature/fix_stream_handler",
99
author="Rachel Duffin",
1010
author_email="rachel.duffin2@nhs.net",
1111
license="Apache License, Version 2.0",

test/test_samplesheet_validator.py

-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66
import os
77
import argparse
88
import pytest
9-
from samplesheet_validator.ss_logger import shutdown_logs
109
from samplesheet_validator import samplesheet_validator
1110
from samplesheet_validator.__main__ import is_valid_dir, is_valid_file
1211

0 commit comments

Comments
 (0)