Add runfolder name to logger, remove timestamp

Author: RachelDuffin

samplesheet_validator/samplesheet_validator.py

@@ -124,8 +124,8 @@ def get_logger(self):
         runfolder_name = (self.samplesheet_path.split("/")[-1]).split(
             "_SampleSheet.csv"
         )[0]
-        logfile_path = f"{os.path.join(self.logdir, runfolder_name)}_{config.TIMESTAMP}_samplesheet_validator.log"
-        return SSLogger(logfile_path).get_logger()
+        logfile_path = f"{os.path.join(self.logdir, runfolder_name)}_samplesheet_validator.log"
+        return SSLogger(logfile_path, runfolder_name).get_logger()
 
     def ss_checks(self) -> None:
         """

samplesheet_validator/ss_logger.py

@@ -13,7 +13,7 @@ def set_root_logger():
     Set up root logger and add stream handler - we only want to add stream handler once
     else it will duplicate log messages to the terminal
     """
-    logger = logging.getLogger()
+    logger = logging.getLogger(__name__)
     logger.setLevel(logging.DEBUG)
     stream_handler = logging.StreamHandler(sys.stdout)
     stream_handler.setLevel(logging.DEBUG)
@@ -29,6 +29,7 @@ class SSLogger:
     Attributes
         timestamp (str):                        Timestamp from config
         logfile_path (str):                     Name of filepath to provide to _file_handler()
+        runfolder_name (str):                   Runfolder name
         logging_formatter (logging.Formatter):  Specifies the layout of log records in the final output
 
     Methods
@@ -40,22 +41,24 @@ class SSLogger:
             Get syslog handler for the logger
     """
 
-    def __init__(self, logfile_path: str):
+    def __init__(self, logfile_path: str, runfolder_name: str):
         """
         Constructor for the Logger class
             :param logfile_path (str):      Path to logfile location
+            :param runfolder_name (str):    Runfolder name
         """
         # Timestamp used for naming log files with datetime, format %Y%m%d_%H%M%S
         self.timestamp = config.TIMESTAMP
         self.logfile_path = logfile_path
+        self.runfolder_name = runfolder_name
         self.logging_formatter = logging.Formatter(config.LOGGING_FORMATTER)
 
     def get_logger(self) -> logging.Logger:
         """
         Returns a Python logging object, and give it a name
             :return logger (object):    Python logging object with custom attributes
         """
-        logger = logging.getLogger()
+        logger = logging.getLogger(f"{__name__}.{self.runfolder_name}")
         logger.filepath = self.logfile_path
         logger.setLevel(logging.DEBUG)
         logger.addHandler(self._get_file_handler())