Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rethink naming for external C libraries #450

Open
avanhatt opened this issue Aug 25, 2021 · 0 comments
Open

Rethink naming for external C libraries #450

avanhatt opened this issue Aug 25, 2021 · 0 comments
Labels
[C] Bug This is a bug. Something isn't working.
Milestone
C-FFI Milestone

Comments

@avanhatt
Copy link
Contributor

avanhatt commented Aug 25, 2021 •
edited
Loading

Right now, linking external C libraries depends on the Rust name pretty printer matching the C type name (see ty_mangled_name). This is fragile and definitely won't work if two different versions of a dependent crate use different versions of C structs. Rethink this.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[C] Bug This is a bug. Something isn't working.
Projects
None yet
Milestone
C-FFI Milestone
Development

No branches or pull requests
3 participants
@danielsn @avanhatt @celinval