fix: when modifying TextMeshPro vertices, element disapear

close #305

Author: mob-sakai

Packages/src/Runtime/UIEffectBase.cs

@@ -1,14 +1,10 @@
-using System.Collections.Generic;
 using System.Runtime.CompilerServices;
 using Coffee.UIEffectInternal;
 using UnityEngine;
 using UnityEngine.EventSystems;
 using UnityEngine.Profiling;
 using UnityEngine.UI;
 using UnityEditor;
-#if TMP_ENABLE
-using TMPro;
-#endif
 
 [assembly: InternalsVisibleTo("UIEffect")]
 [assembly: InternalsVisibleTo("Coffee.UIEffect.Editor")]
@@ -19,9 +15,6 @@ namespace Coffee.UIEffects
     [DisallowMultipleComponent]
     public abstract class UIEffectBase : UIBehaviour, IMeshModifier, IMaterialModifier, ICanvasRaycastFilter
     {
-        private static readonly VertexHelper s_VertexHelper = new VertexHelper();
-        private static Mesh s_Mesh;
-
         private static readonly InternalObjectPool<UIEffectContext> s_ContextPool =
             new InternalObjectPool<UIEffectContext>(() => new UIEffectContext(), x => true, x => x.Reset());
 
@@ -52,27 +45,13 @@ public virtual UIEffectContext context
 
         protected override void OnEnable()
         {
-#if TMP_ENABLE
-            if (graphic is TextMeshProUGUI)
-            {
-                _prevLossyScaleY = transform.lossyScale.y;
-                Canvas.willRenderCanvases += CheckSDFScaleForTMP;
-                UIExtraCallbacks.onScreenSizeChanged += SetVerticesDirtyForTMP;
-            }
-#endif
-
             UpdateContext(context);
             SetMaterialDirty();
             SetVerticesDirty();
         }
 
         protected override void OnDisable()
         {
-#if TMP_ENABLE
-            Canvas.willRenderCanvases -= CheckSDFScaleForTMP;
-            UIExtraCallbacks.onScreenSizeChanged -= SetVerticesDirtyForTMP;
-#endif
-
             MaterialRepository.Release(ref _material);
             SetMaterialDirty();
             SetVerticesDirty();
@@ -159,24 +138,10 @@ protected override void OnDidApplyAnimationProperties()
 
         public virtual void SetVerticesDirty()
         {
-#if TMP_ENABLE
-            if (graphic is TextMeshProUGUI textMeshProUGUI && textMeshProUGUI.isActiveAndEnabled)
-            {
-                if (isActiveAndEnabled)
-                {
-                    OnTMPChanged(textMeshProUGUI);
-                }
-                else if (0 < textMeshProUGUI.textInfo?.meshInfo?.Length
-                         && 0 < textMeshProUGUI.textInfo.meshInfo[0].vertexCount)
-                {
-                    textMeshProUGUI.UpdateVertexData();
-                }
-            }
-            else
-#endif
             if (graphic)
             {
                 graphic.SetVerticesDirty();
+                GraphicProxy.Find(graphic).SetVerticesDirty(graphic);
 #if UNITY_EDITOR
                 EditorApplication.QueuePlayerLoopUpdate();
 #endif
@@ -211,122 +176,6 @@ public virtual void ApplyContextToMaterial()
 #endif
         }
 
-#if TMP_ENABLE
-#if UNITY_EDITOR
-        [InitializeOnLoadMethod]
-#else
-        [RuntimeInitializeOnLoadMethod(RuntimeInitializeLoadType.BeforeSceneLoad)]
-#endif
-        private static void InitializeOnLoad()
-        {
-            TMPro_EventManager.TEXT_CHANGED_EVENT.Add(obj =>
-            {
-                if (obj is TextMeshProUGUI textMeshProUGUI)
-                {
-                    OnTMPChanged(textMeshProUGUI);
-                }
-            });
-        }
-
-        private static void OnTMPChanged(TextMeshProUGUI textMeshProUGUI)
-        {
-            if (!textMeshProUGUI.TryGetComponent<UIEffectBase>(out var effect)) return;
-            if (!effect || !effect.isActiveAndEnabled) return;
-
-            if (!s_Mesh)
-            {
-                s_Mesh = new Mesh();
-                s_Mesh.MarkDynamic();
-            }
-
-            var target = effect is UIEffect uiEffect
-                ? uiEffect
-                : effect is UIEffectReplica parentReplica
-                    ? parentReplica.target
-                    : null;
-            var subMeshes = InternalListPool<TMP_SubMeshUI>.Rent();
-            var modifiers = InternalListPool<IMeshModifier>.Rent();
-            textMeshProUGUI.GetComponentsInChildren(subMeshes, 1);
-            for (var i = 0; i < textMeshProUGUI.textInfo.meshInfo.Length; i++)
-            {
-                var meshInfo = textMeshProUGUI.textInfo.meshInfo[i];
-                s_VertexHelper.Clear();
-                meshInfo.mesh.CopyTo(s_VertexHelper, meshInfo.vertexCount, meshInfo.vertexCount * 6 / 4);
-                if (i == 0)
-                {
-                    textMeshProUGUI.GetComponents(modifiers);
-                    foreach (var modifier in modifiers)
-                    {
-                        modifier.ModifyMesh(s_VertexHelper);
-                    }
-
-                    s_VertexHelper.FillMesh(s_Mesh);
-                    textMeshProUGUI.canvasRenderer.SetMesh(s_Mesh);
-                }
-                else if (i - 1 < subMeshes.Count)
-                {
-                    var subMeshUI = GetSubMeshUI(subMeshes, meshInfo.material, i - 1);
-                    if (!target || !subMeshUI) break;
-
-                    var replica = subMeshUI.GetOrAddComponent<UIEffectReplica>();
-                    replica.target = target;
-
-                    subMeshUI.GetComponents(modifiers);
-                    foreach (var modifier in modifiers)
-                    {
-                        modifier.ModifyMesh(s_VertexHelper);
-                    }
-
-                    s_VertexHelper.FillMesh(s_Mesh);
-                    replica.ApplyContextToMaterial();
-                    subMeshUI.canvasRenderer.SetMesh(s_Mesh);
-                }
-                else
-                {
-                    break;
-                }
-            }
-
-            InternalListPool<IMeshModifier>.Return(ref modifiers);
-            InternalListPool<TMP_SubMeshUI>.Return(ref subMeshes);
-            s_Mesh.Clear(false);
-        }
-
-        private static TMP_SubMeshUI GetSubMeshUI(List<TMP_SubMeshUI> subMeshes, Material material, int start)
-        {
-            var count = subMeshes.Count;
-            for (var j = 0; j < count; j++)
-            {
-                var s = subMeshes[(j + start + count) % count];
-                if (s.sharedMaterial == material) return s;
-            }
-
-            return null;
-        }
-
-        private void SetVerticesDirtyForTMP()
-        {
-            if (graphic && graphic.isActiveAndEnabled)
-            {
-                graphic.SetVerticesDirty();
-            }
-        }
-
-        private void CheckSDFScaleForTMP()
-        {
-            var lossyScaleY = transform.lossyScale.y;
-            if (Mathf.Approximately(_prevLossyScaleY, lossyScaleY)) return;
-
-            _prevLossyScaleY = lossyScaleY;
-            if (graphic is TextMeshProUGUI textMeshProUGUI && graphic.isActiveAndEnabled)
-            {
-                OnTMPChanged(textMeshProUGUI);
-            }
-        }
-
-        private float _prevLossyScaleY;
-#endif
-
         public abstract void SetRate(float rate, UIEffectTweener.CullingMask cullingMask);
         public abstract bool IsRaycastLocationValid(Vector2 sp, Camera eventCamera);
     }

Packages/src/Runtime/UIEffectContext.cs

@@ -434,9 +434,9 @@ private static void SetKeyword(Material material, string[] keywords, int index)
 
         public void ModifyMesh(Graphic graphic, RectTransform transitionRoot, VertexHelper vh, bool canModifyShape)
         {
-            var processor = ContextProcessor.FindProcessor(graphic);
-            var isText = processor.IsText(graphic);
-            processor.OnPreModifyMesh(graphic);
+            var effectProxy = GraphicProxy.Find(graphic);
+            var isText = effectProxy.IsText(graphic);
+            effectProxy.OnPreModifyMesh(graphic);
 
             var verts = s_WorkingVertices;
             var expandSize = GetExpandSize(canModifyShape);