Merge pull request #1283 from mito-ds/graph-undo-bug

Fix bug when opening graph editor then pressing undo

Author: marthacryan

mitosheet/src/mito/Mito.tsx

@@ -335,6 +335,23 @@ export const Mito = (props: MitoProps): JSX.Element => {
         loadPlotly()
     }, [])
 
+    /**
+     * This useEffect handles when the user creates a graph, then presses undo.
+     */
+    useEffect(() => {
+        if (uiState.currOpenTaskpane.type === TaskpaneType.GRAPH &&
+            analysisData.graphDataArray.length === 0) {
+            setUIState(prevUIState => {
+                return {
+                    ...prevUIState,
+                    currOpenTaskpane: {type: TaskpaneType.NONE},
+                    selectedTabType: 'data',
+                    selectedSheetIndex: 0
+                }
+            })
+        }
+    }, [analysisData.graphDataArray.length])
+
     /* 
         When the number of sheets increases, we make sure
         that the last sheet is highlighted. If it decreases,

tests/streamlit_ui_tests/graph.spec.ts

@@ -193,6 +193,14 @@ test.describe('Graph Functionality', () => {
     await expect(mito.getByText('Facet row')).toBeInViewport();
   });
 
+  test('Pressing undo after opening graph editor closes the graph editor', async ({ page }) => {
+    const mito = await getMitoFrameWithTestCSV(page);
+    await openGraphEditor(mito, page);
+    await mito.getByTitle(/Undo the most recent edit/).click();
+    await expect(mito.locator('.tab-selected', { hasText: 'test' })).toBeVisible();
+    await expect(mito.locator('.endo-column-header-final-text').first()).toHaveText('Column1');
+  });
+
   test('Make a histogram and change the histogram specific configurations', async ({ page }) => {
     const mito = await getMitoFrameWithTestCSV(page);