Skip to content

Commit f0dda17

Browse files
committed
mitosheet: fix types for python 3.6
1 parent 97b6765 commit f0dda17

File tree

3 files changed

+10
-8
lines changed

3 files changed

+10
-8
lines changed

mitosheet/mitosheet/mito_backend.py

+3-3
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
import re
1313
import time
1414
from sysconfig import get_python_version
15-
from typing import Any, Dict, List, Literal, Optional, Union, Callable
15+
from typing import Any, Dict, List, Optional, Union, Callable
1616

1717
import numpy as np
1818
import pandas as pd
@@ -29,7 +29,7 @@
2929
from mitosheet.steps_manager import StepsManager
3030
from mitosheet.telemetry.telemetry_utils import (log, log_event_processed,
3131
telemetry_turned_on)
32-
from mitosheet.types import CodeOptions, ColumnDefinintion, ColumnDefinitions, ConditionalFormat, MitoTheme, ParamMetadata
32+
from mitosheet.types import CodeOptions, ColumnDefinintion, ColumnDefinitions, ConditionalFormat, DefaultEditingMode, MitoTheme, ParamMetadata
3333
from mitosheet.updates.replay_analysis import REPLAY_ANALYSIS_UPDATE
3434
from mitosheet.user.create import try_create_user_json_file
3535
from mitosheet.user.db import USER_JSON_PATH, get_user_field
@@ -58,7 +58,7 @@ def __init__(
5858
user_defined_editors: Optional[List[Callable]]=None,
5959
code_options: Optional[CodeOptions]=None,
6060
column_definitions: Optional[List[ColumnDefinitions]]=None,
61-
default_editing_mode: Optional[Literal['cell', 'column']]=None,
61+
default_editing_mode: Optional[DefaultEditingMode]=None,
6262
theme: Optional[MitoTheme]=None,
6363
):
6464
"""

mitosheet/mitosheet/streamlit/v1/spreadsheet.py

+4-4
Original file line numberDiff line numberDiff line change
@@ -7,13 +7,13 @@
77
import os
88
import pickle
99
import re
10-
from typing import Any, Dict, List, Callable, Literal, Optional, Tuple, Union
10+
from typing import Any, Dict, List, Callable, Optional, Tuple, Union
1111

1212
import pandas as pd
1313

1414
from mitosheet.mito_backend import MitoBackend
1515
from mitosheet.selection_utils import get_selected_element
16-
from mitosheet.types import CodeOptions, ColumnDefinitions, ConditionalFormat, ParamMetadata, ParamType
16+
from mitosheet.types import CodeOptions, ColumnDefinitions, ConditionalFormat, DefaultEditingMode, ParamMetadata, ParamType
1717
from mitosheet.user.utils import is_pro
1818
from mitosheet.utils import get_new_id
1919

@@ -271,7 +271,7 @@ def _get_mito_backend(
271271
_sheet_functions: Optional[List[Callable]]=None,
272272
_code_options: Optional[CodeOptions]=None,
273273
_column_definitions: Optional[List[ColumnDefinitions]]=None,
274-
_default_editing_mode: Optional[Literal['cell', 'column']]=None,
274+
_default_editing_mode: Optional[DefaultEditingMode]=None,
275275
import_folder: Optional[str]=None,
276276
df_names: Optional[List[str]]=None,
277277
session_id: Optional[str]=None,
@@ -326,7 +326,7 @@ def spreadsheet( # type: ignore
326326
import_folder: Optional[str]=None,
327327
code_options: Optional[CodeOptions]=None,
328328
column_definitions: Optional[List[ColumnDefinitions]]=None,
329-
default_editing_mode: Optional[Literal['cell', 'column']]=None,
329+
default_editing_mode: Optional[DefaultEditingMode]=None,
330330
return_type: str='default',
331331
height: Optional[str]=None,
332332
key=None

mitosheet/mitosheet/types.py

+3-1
Original file line numberDiff line numberDiff line change
@@ -383,9 +383,10 @@ class ColumnDefinintion(TypedDict):
383383
columns: List[ColumnHeader]
384384
conditional_formats: List[ColumnDefinitionConditionalFormats]
385385

386-
# TODO: This is a confusing name. Think of a better one.
387386
ColumnDefinitions = List[ColumnDefinintion]
388387

388+
DefaultEditingMode = Literal['cell', 'column']
389+
389390
UserDefinedFunctionParamType = Literal['any', 'str', 'int', 'float', 'bool', 'DataFrame', 'ColumnHeader']
390391

391392
class MitoTheme(TypedDict):
@@ -455,6 +456,7 @@ class ExecuteThroughTranspileNewDataframeParams(TypedDict):
455456
ColumnDefinitionConditionalFormats = Any # type: ignore
456457
ColumnDefinintion = Any # type: ignore
457458
ColumnDefinitions = Any # type: ignore
459+
DefaultEditingMode = Any # type: ignore
458460

459461
ParamName = str # type: ignore
460462
ParamType = str # type: ignore

0 commit comments

Comments
 (0)