Merge pull request #1277 from mito-ds/double-click-bug

Fix bug when double-clicking cell while cell editor is open

Author: marthacryan

mitosheet/src/mito/components/endo/EndoGrid.tsx

@@ -544,6 +544,9 @@ function EndoGrid(props: {
 
     // On double click, open the cell editor on this cell
     const onDoubleClick = (e: React.MouseEvent<HTMLDivElement, MouseEvent>) => {
+        if (editorState !== undefined) {
+            return;
+        }
         const {rowIndex, columnIndex} = getIndexesFromMouseEvent(e);
         // Don't open for headers
         if ((rowIndex === undefined || columnIndex === undefined) || getIsHeader(rowIndex, columnIndex)) {

tests/streamlit_ui_tests/grid/set_column_formula_tests.spec.ts

@@ -143,6 +143,21 @@ test('Reference cell in previous row by clicking on it', async ({ page }) => {
     expect(cellValues).toEqual(['0', '1', '4', '7']);
 });
 
+test('Double clicking on cell while cell editor is open does not close cell editor', async ({ page }) => {
+    const columnHeader = 'Column4';
+
+    const mito = await getMitoFrameWithTestCSV(page);
+    await createNewColumn(page, mito, 3, columnHeader);
+
+    const cell = await getCellAtRowIndexAndColumnName(mito, 0, columnHeader);
+    await cell.dblclick();
+    await mito.getByRole('textbox').fill('=');
+
+    const otherCell = await getCellAtRowIndexAndColumnName(mito, 0, 'Column1');
+    await otherCell.dblclick();
+    await expect(mito.locator('#cell-editor-input')).toHaveValue('=Column10');
+});
+
 test('Use arrow keys to select cell', async ({ page }) => {
     const columnHeader = 'Column4';