Merge pull request #1240 from mito-ds/code-config-tests

Add code config tests

Author: aarondr77

mitosheet/src/mito/components/taskpanes/CodeOptions/CodeOptionsTaskpane.tsx

@@ -29,14 +29,8 @@ interface CodeOptionsTaskpaneProps {
 const CodeOptionsTaskpane = (props: CodeOptionsTaskpaneProps): JSX.Element => {
 
     const [codeOptions, setCodeOptions] = useState(() => props.analysisData.codeOptions);
-    const [firstRender, setFirstRender] = useState(true);
 
     useDebouncedEffect(() => {
-        if (firstRender) {
-            setFirstRender(false);
-            return;
-        }
-
         void props.mitoAPI.updateCodeOptions(codeOptions);
     }, [codeOptions], 500);
 
@@ -62,7 +56,7 @@ const CodeOptionsTaskpane = (props: CodeOptionsTaskpaneProps): JSX.Element => {
                     </Col>
                     <Col>
                         <Toggle 
-                            value={props.analysisData.codeOptions.as_function} 
+                            value={codeOptions.as_function} 
                             onChange={function (): void {
                                 const newCodeOptions = {...codeOptions};
                                 newCodeOptions.as_function = !newCodeOptions.as_function;

tests/streamlit_test.py

@@ -4,4 +4,5 @@
 st.set_page_config(layout="wide")
 
 
-spreadsheet(import_folder='data')
+dfs, code = spreadsheet(import_folder='data')
+st.code(code)

tests/streamlit_ui_tests/taskpanes/code_config.spec.ts

@@ -1,18 +1,33 @@
-import { test } from '@playwright/test';
+import { expect, test } from '@playwright/test';
 import { checkOpenTaskpane, clickTab, getMitoFrameWithTestCSV } from '../utils';
 
 
 test.describe('Code Config', () => {
-    test.skip('Test Configure Code', async ({ page }) => {
-        const mito = await getMitoFrameWithTestCSV(page);
-        await clickTab(page, mito, 'Code');
+  test('Configure Code to generate function with new name for function', async ({ page }) => {
+    const mito = await getMitoFrameWithTestCSV(page);
+    await clickTab(page, mito, 'Code');
+
+    await mito.getByRole('button', { name: 'Configure Code' }).click();
+    await checkOpenTaskpane(mito, 'Generated Code Options');
+
+    await mito.locator('.spacing-row', { hasText: 'Generate Function' }).locator('.toggle').click();
+    await mito.getByRole('textbox').fill('new name');
 
-        await mito.getByRole('button', { name: 'Configure Code' }).click();
-        await checkOpenTaskpane(mito, 'Generated Code Options');
+    await expect(page.locator('.stCodeBlock')).toContainText('def new_name():');
+  });
+
+  test('Configure Code to generate function with parameters', async ({ page }) => {
+    const mito = await getMitoFrameWithTestCSV(page);
+    await clickTab(page, mito, 'Code');
+
+    await mito.getByRole('button', { name: 'Configure Code' }).click();
+    await checkOpenTaskpane(mito, 'Generated Code Options');
+
+    await mito.locator('.spacing-row', { hasText: 'Generate Function' }).locator('.toggle').click();
+    await mito.getByRole('textbox').fill('new name');
+    await mito.getByText('Add').click();
+    await mito.locator('.mito-dropdown-item', { hasText: 'CSV Import File Path' }).click();
 
-        await mito.locator('.toggle').first().click();
-        await mito.getByRole('textbox').fill('new name');
-        
-        // TODO: check some output
-      });
+    await expect(page.locator('.stCodeBlock')).toContainText('def new_name(r\'');
+  });
 });