Skip to content

Commit ba4bfea

Browse files
committed
Address review
1 parent 3eb8c4a commit ba4bfea

File tree

1 file changed

+14
-4
lines changed

1 file changed

+14
-4
lines changed

tests/streamlit_ui_tests/grid/keyboard_shortcuts.spec.ts

+14-4
Original file line numberDiff line numberDiff line change
@@ -54,27 +54,37 @@ test.describe('Keyboard Shortcuts', () => {
5454

5555
test('Next/prev sheet with graphs', async ({ page }) => {
5656
const mito = await getMitoFrameWithTestCSV(page);
57+
58+
/* Import another csv and create 2 graphs so that we have enough tabs to navigate between */
5759
await importCSV(page, mito, 'test.csv');
60+
61+
// Create a graph
5862
await mito.getByText('Graph').click();
5963
await expect(mito.getByText('Column1 bar chart')).toBeVisible();
64+
65+
// Create another graph off of test_1
6066
await mito.locator('.tab', { hasText: 'test_1' }).click();
6167
await mito.getByText('Graph', { exact: true }).click();
6268
await expect(mito.getByText('Column1 bar chart')).toBeVisible();
6369

70+
/* Test navigation */
6471
await mito.locator('.mito-container').press('Alt+ArrowRight');
65-
await awaitResponse(page);
6672
await expect(mito.locator('.tab-selected')).toHaveText('test');
73+
6774
await mito.locator('.mito-container').press('Alt+ArrowRight');
68-
await awaitResponse(page);
6975
await expect(mito.locator('.tab-selected')).toHaveText('test_1');
7076

7177
await mito.locator('.mito-container').press('Alt+ArrowRight');
72-
await awaitResponse(page);
7378
await expect(mito.locator('.tab-selected')).toHaveText('graph0');
7479

7580
await mito.locator('.mito-container').press('Alt+ArrowLeft');
76-
await awaitResponse(page);
7781
await expect(mito.locator('.tab-selected')).toHaveText('test_1');
82+
83+
await mito.locator('.mito-container').press('Alt+ArrowLeft');
84+
await expect(mito.locator('.tab-selected')).toHaveText('test');
85+
86+
await mito.locator('.mito-container').press('Alt+ArrowLeft');
87+
await expect(mito.locator('.tab-selected')).toHaveText('graph1');
7888
});
7989

8090
test('Previous Sheet', async ({ page }) => {

0 commit comments

Comments
 (0)