Merge pull request #1219 from mito-ds/nate-testing-cleanup

Add pivot tests

Author: marthacryan

mitosheet/src/mito/components/endo/IndexHeaders.tsx

@@ -40,6 +40,11 @@ const IndexHeaders = (props: {
                     <div style={indexHeadersStyle}>
                         {Array(currentSheetView.numRowsRendered).fill(0).map((_, _rowIndex) => {
                             const rowIndex = currentSheetView.startingRowIndex + _rowIndex;
+
+                            if (rowIndex >= props.sheetData.numRows) {
+                                return null;
+                            }
+
                             const selected = getIsCellSelected(
                                 props.gridState.selections,
                                 rowIndex,

tests/streamlit_ui_tests/features/graph.spec.ts

@@ -112,7 +112,7 @@ test.describe('Graph Functionality', () => {
     await openGraphEditor(mito, page);
 
     await expect(mito.locator('.graph-sidebar-toolbar-content .select-container').nth(1)).toHaveText('Column1');
-    await expect(mito.locator('.graph-sidebar-toolbar-content .select-container').nth(2)).toHaveText('Column2');
+    await expect(mito.locator('.graph-sidebar-toolbar-content .select-container').nth(2)).toHaveText('Column2');  
   })
 
   test('Change Chart type to Linear', async ({ page }) => {

tests/streamlit_ui_tests/features/merge.spec.ts

@@ -1,5 +1,5 @@
 import { FrameLocator, Page, expect, test } from '@playwright/test';
-import { awaitResponse, clickButtonAndAwaitResponse, closeTaskpane, getColumnHeaderContainer, getMitoFrame, getMitoFrameWithTestCSV, hasExpectedNumberOfRows, importCSV } from '../utils';
+import { awaitResponse, checkColumnCount, checkColumnExists, clickButtonAndAwaitResponse, closeTaskpane, getColumnHeaderContainer, getMitoFrame, getMitoFrameWithTestCSV, hasExpectedNumberOfRows, importCSV } from '../utils';
 
 
 const changeMergeType = async (mito: FrameLocator, page: Page, mergeType: string) => {
@@ -37,9 +37,7 @@ test.describe('Merge', () => {
 
         await expect(mito.getByText('Merge Dataframes')).toBeVisible();
 
-        // Check that Column1 exists
-        const ch1 = await getColumnHeaderContainer(mito, 'Column1');
-        await expect(ch1).toBeVisible();
+        await checkColumnExists(mito, 'Column1');
 
         // Close the taskpane
         await closeTaskpane(mito);
@@ -51,12 +49,7 @@ test.describe('Merge', () => {
         // Add a merge key
         await mito.getByRole('button', { name: '+ Add Merge Keys' }).click();
 
-        const newCh1 = await getColumnHeaderContainer(mito, 'Column1');
-        await expect(newCh1).toBeVisible();
-        const newCh2 = await getColumnHeaderContainer(mito, 'Column2');
-        await expect(newCh2).toBeVisible();
-        const Column3_test_1 = await getColumnHeaderContainer(mito, 'Column3_test_1');
-        await expect(Column3_test_1).toBeVisible();
+        await checkColumnExists(mito, ['Column1', 'Column2', 'Column3_test_1']);
     });
 
 
@@ -73,17 +66,15 @@ test.describe('Merge', () => {
         // Wait for the merge to be finished before continuing so adding a column works!
         await expect(mito.getByText('df_merge')).toBeVisible();
 
-        // Check that Column1 exists
-        const ch1 = await getColumnHeaderContainer(mito, 'Column1');
-        await expect(ch1).toBeVisible();
+        await checkColumnExists(mito, 'Column1');
 
         // Add a column
         await mito.locator('[id="mito-toolbar-button-add\\ column\\ to\\ the\\ right"]').getByRole('button', { name: 'Insert' }).click();
         await awaitResponse(page);
 
         // Check that the merge table has been updated -- there should be
         // 5 columns from merge + 1 added
-        await expect(mito.locator('.endo-column-header-container')).toHaveCount(6);
+        await checkColumnCount(mito, 6);
 
         // Reopen the edit merge
         await mito.getByText('df_merge').click({button: 'right'});
@@ -92,15 +83,9 @@ test.describe('Merge', () => {
         // Add a merge key
         await mito.getByRole('button', { name: '+ Add Merge Keys' }).click();
 
-        const newCh1 = await getColumnHeaderContainer(mito, 'Column1');
-        await expect(newCh1).toBeVisible();
-        const newCh2 = await getColumnHeaderContainer(mito, 'Column2');
-        await expect(newCh2).toBeVisible();
-        const Column3_test_1 = await getColumnHeaderContainer(mito, 'Column3_test_1');
-        await expect(Column3_test_1).toBeVisible();
-
-        // Check that there are 5 columns still
-        await expect(mito.locator('.endo-column-header-container')).toHaveCount(5);
+        // Check the new columns
+        await checkColumnExists(mito, ['Column1', 'Column2', 'Column3_test_1']);
+        await checkColumnCount(mito, 5);
     });
 
     test('Change Merge Type', async ({ page }) => {