Skip to content

Commit b265a84

Browse files
committed
Core logging default tags
1 parent 55187ac commit b265a84

File tree

3 files changed

+14
-10
lines changed

3 files changed

+14
-10
lines changed

terraform/environments/core-logging/providers.tf

+4
Original file line numberDiff line numberDiff line change
@@ -4,12 +4,14 @@ provider "aws" {
44
assume_role {
55
role_arn = "arn:aws:iam::${local.environment_management.account_ids[terraform.workspace]}:role/ModernisationPlatformAccess"
66
}
7+
default_tags { tags = local.tags }
78
}
89

910
# AWS provider for the Modernisation Platform, to get things from there if required
1011
provider "aws" {
1112
alias = "modernisation-platform"
1213
region = "eu-west-2"
14+
default_tags { tags = local.tags }
1315
}
1416

1517
provider "aws" {
@@ -18,6 +20,7 @@ provider "aws" {
1820
assume_role {
1921
role_arn = "arn:aws:iam::${local.environment_management.account_ids["core-logging-production"]}:role/ModernisationPlatformAccess"
2022
}
23+
default_tags { tags = local.tags }
2124
}
2225

2326
# AWS provider for core-network-services to get the Transit Gateway attachment
@@ -27,4 +30,5 @@ provider "aws" {
2730
assume_role {
2831
role_arn = "arn:aws:iam::${local.environment_management.account_ids["core-network-services-production"]}:role/ModernisationPlatformAccess"
2932
}
33+
default_tags { tags = local.tags }
3034
}

terraform/environments/core-logging/r53_logs.tf

+8-8
Original file line numberDiff line numberDiff line change
@@ -8,19 +8,19 @@ locals {
88
resource "aws_route53_resolver_query_log_config" "s3" {
99
name = format("%s-rlq-s3", local.application_name)
1010
destination_arn = aws_s3_bucket.logging["r53-resolver-logs"].arn
11-
tags = local.tags
11+
tags = {}
1212
}
1313

1414
resource "aws_route53_resolver_query_log_config" "cloudwatch" {
1515
name = format("%s-rlq-cloudwatch", local.application_name)
1616
destination_arn = aws_cloudwatch_log_group.r53_resolver_logs.arn
17-
tags = local.tags
17+
tags = {}
1818
}
1919

2020
resource "aws_ram_resource_share" "resolver_query_share" {
2121
allow_external_principals = false
2222
name = format("%s-resolver-log-query-share", local.application_name)
23-
tags = local.tags
23+
tags = {}
2424
}
2525

2626
resource "aws_ram_resource_association" "resolver_query_share" {
@@ -38,15 +38,15 @@ resource "aws_cloudwatch_log_group" "r53_resolver_logs" {
3838
kms_key_id = aws_kms_key.r53_resolver_logs.arn
3939
name_prefix = "r53-resolver-logs"
4040
retention_in_days = 365
41-
tags = local.tags
41+
tags = {}
4242
}
4343

4444
resource "aws_kms_key" "r53_resolver_logs" {
4545
description = "KMS key used to encrypt R53 Resolver Logs CloudWatch log group"
4646
enable_key_rotation = true
4747
multi_region = true
4848
policy = data.aws_iam_policy_document.r53_resolver_logs_kms.json
49-
tags = local.tags
49+
tags = {}
5050
}
5151

5252
data "aws_iam_policy_document" "r53_resolver_logs_kms" {
@@ -113,20 +113,20 @@ resource "aws_cloudwatch_metric_alarm" "r53_dns_firewall_alarm" {
113113
statistic = "Sum"
114114
threshold = "1"
115115
alarm_actions = [aws_sns_topic.r53_dns_firewall.arn]
116-
tags = local.tags
116+
tags = {}
117117
}
118118

119119
resource "aws_sns_topic" "r53_dns_firewall" {
120120
name = "r53-dns-firewall-sns-topic"
121121
kms_master_key_id = aws_kms_key.r53_dns_firewall.key_id
122-
tags = local.tags
122+
tags = {}
123123
}
124124

125125
resource "aws_kms_key" "r53_dns_firewall" {
126126
description = "KMS key for DNS Firewall SNS Topic Encryption"
127127
enable_key_rotation = true
128128
policy = data.aws_iam_policy_document.r53_dns_firewall_kms_policy.json
129-
tags = local.tags
129+
tags = {}
130130
}
131131

132132
resource "aws_kms_alias" "r53_dns_firewall" {

terraform/environments/core-logging/s3_logging.tf

+2-2
Original file line numberDiff line numberDiff line change
@@ -217,7 +217,7 @@ module "s3-bucket-cloudtrail" {
217217
}
218218
]
219219
log_bucket = module.s3-bucket-cloudtrail-logging.bucket.id
220-
tags = local.tags
220+
tags = {}
221221
}
222222
# Allow access to the bucket from the MoJ root account
223223
# Policy extrapolated from:
@@ -344,5 +344,5 @@ module "s3-bucket-cloudtrail-logging" {
344344
}
345345
]
346346

347-
tags = local.tags
347+
tags = {}
348348
}

0 commit comments

Comments
 (0)