better name for is_access_requirements... for context key

Author: LavMatt

home/service/details.py

@@ -69,7 +69,7 @@ def _get_context(self):
             ),
             "h1_value": self.database_metadata.name,
             "is_esda": self.is_esda,
-            "is_access_requirements_url": is_access_requirements_a_url(
+            "is_access_requirements_a_url": is_access_requirements_a_url(
                 self.database_metadata.custom_properties.access_information.access_requirements
             ),
         }
@@ -107,7 +107,7 @@ def _get_context(self):
             "h1_value": self.table_metadata.name,
             "has_lineage": self.has_lineage(),
             "lineage_url": f"{split_datahub_url.scheme}://{split_datahub_url.netloc}/dataset/{self.table_metadata.urn}/Lineage?is_lineage_mode=true&",  # noqa: E501
-            "is_access_requirements_url": is_access_requirements_a_url(
+            "is_access_requirements_a_url": is_access_requirements_a_url(
                 self.table_metadata.custom_properties.access_information.access_requirements
             ),
         }
@@ -140,7 +140,7 @@ def _get_context(self):
             "parent_entity": self.parent_entity,
             "parent_type": ResultType.DASHBOARD.name.lower(),
             "h1_value": self.chart_metadata.name,
-            "is_access_requirements_url": is_access_requirements_a_url(
+            "is_access_requirements_a_url": is_access_requirements_a_url(
                 self.chart_metadata.custom_properties.access_information.access_requirements
             ),
         }
@@ -163,7 +163,7 @@ def _get_context(self):
                 self.children,
                 key=lambda d: d.entity_ref.display_name,
             ),
-            "is_access_requirements_url": is_access_requirements_a_url(
+            "is_access_requirements_a_url": is_access_requirements_a_url(
                 self.dashboard_metadata.custom_properties.access_information.access_requirements
             ),
         }

templates/details_base.html

@@ -90,7 +90,7 @@ <h3 class="govuk-heading-s govuk-!-margin-top-3">
       </div>
     </div>
     <div class="govuk-grid-column-one-third">
-      {% include "partial/contact_info.html" with data_owner=entity.governance.data_owner.display_name data_owner_email=entity.governance.data_owner.email slack_channel=entity.custom_properties.further_information access_requirements=entity.custom_properties.access_information.access_requirements is_access_url=is_access_requirements_url%}
+      {% include "partial/contact_info.html" with data_owner=entity.governance.data_owner.display_name data_owner_email=entity.governance.data_owner.email slack_channel=entity.custom_properties.further_information access_requirements=entity.custom_properties.access_information.access_requirements is_access_url=is_access_requirements_a_url%}
     </div>
   </div>