Move deploy webhooks to vault and allow different webhooks per site #3
+23
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice one @dalepgrant, yeah seems like a nicer solution - I was notifying across multiple organisations, not multiple channels in the same org - but this would still allow that which is great! 👍 |
|
Awesome, hope it helps! A webhook per channel is a bit annoying to set up when you've got lots, but 🤷♂️ what can you do. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mike-sheppard building on what you'd done previously, this PR moves webhook tokens to an environment's
vault.ymland allows you to notify multiple channels per site, per environment.Looks like since you submitted your PR the Slack API has changed (unless I'm missing something?) so that a webhook can only notify one channel, so I've removed the ability to specify a channel. Each channel you wish to notify must have it's own webhook set up: in our use case this is perfect as we have a Slack channel per client, and an
engineeringchannel that we can post staging deploys to. Have tested this and it also works with channels shared with other teams.I'll submit this to Itineris, but figured as it's based on your work, I'd PR with your repo too.