Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Console logger has a hardcoded path separator for the source #3376

Closed
MarinAtanasov opened this issue Feb 16, 2022 · 1 comment · Fixed by #3923
Closed

Console logger has a hardcoded path separator for the source #3376

MarinAtanasov opened this issue Feb 16, 2022 · 1 comment · Fixed by #3923
Assignees

Comments

@MarinAtanasov
Copy link

Description

vstest console logger has a hardcoded path separator for the source:

var sourceName = sd.Key.Split('\\').Last();

Steps to reproduce

  1. Checkout https://github.com/MarinAtanasov/AppBrix
  2. Run ./Test.ps -Build
  3. Look at the output in the console

Expected behavior

On Linux, Windows and MacOS, the output should be the same:

Passed!  - Failed:     0, Passed:    20, Skipped:     0, Total:    20, Duration: 77 ms - AppBrix.Tests.dll (net6.0)

Actual behavior

On Linux and MacOS, the output contains the full path to the test assembly:

Passed!  - Failed:     0, Passed:    20, Skipped:     0, Total:    20, Duration: 100 ms - /home/runner/work/AppBrix/AppBrix/Tests/AppBrix.Tests/bin/Release/net6.0/AppBrix.Tests.dll (net6.0)

The issue will probably be reproduced if Windows is set to use a different path separator.

Diagnostic logs

Not necessary.

Environment

I am running this GitHub action, which is using ubuntu-latest, windows-latest and macOS-latest with dotnet-version: 6.0.x

@Evangelink Evangelink self-assigned this Jul 26, 2022
@Evangelink
Copy link
Member

Thank you for reporting this @MarinAtanasov. I confirm that I can reproduce the issue:

Passed!  - Failed:     0, Passed:   120, Skipped:     0, Total:   120, Duration: 51 ms - /home/amaury/src/AppBrix/Tests/AppBrix.Permissions.Tests/bin/Debug/net6.0/AppBrix.Permissions.Tests.dll (net6.0)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants