Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.tsx code format broken #9067

Closed
mbilling opened this issue Jul 11, 2016 · 3 comments
Closed

.tsx code format broken #9067

mbilling opened this issue Jul 11, 2016 · 3 comments
Assignees
Labels
typescript Typescript support issues upstream Issue identified as 'upstream' component related (exists outside of VS Code)

Comments

@mbilling
Copy link

mbilling commented Jul 11, 2016

  • VSCode Version: Code - Insiders 1.4.0-insider (f6227ca, 2016-07-11T05:07:20.965Z)
  • OS Version: Windows_NT ia32 10.0.10586

Steps to Reproduce:

  1. Open new VSCODE
  2. Paste kode from file Configurations.txt into Untitled-1
  3. Save as e.g. "test.tsx"
  4. Jump to line 1457
  5. Press Alt + Shift + F or run format code command
  6. Nothing happens - code is still the same (i believe the format code service dies here)
  7. Create a new .tsx file make some simple typescript, e.g.
function(test:string)
   {
      let example      =   test;
   } 
  1. Press Alt + Shift + F and nothing happens. You need ´to restart VSCode to run "Format Code" again

/Michael

@mbilling
Copy link
Author

mbilling commented Jul 11, 2016

Also try and fold the code on the render() method (line 1294)
This shows a bug in code folding - maybe there are some issues reported on that too.
So maybe a fix fixes multiple bugs

@aeschli aeschli assigned dbaeumer and unassigned aeschli Jul 12, 2016
@dbaeumer
Copy link
Member

Was able to reproduce this. It is a bug in the tsserver. The request returns with the following error:

Response received: configure (7). Request took 3 ms. Success: true 
Sending request: format (8). Response expected: yes. Current queue length: 0
Arguments: {
    "file": "p:/mseng/VSCode/Playgrounds/bugs/9067/test.tsx",
    "line": 1,
    "offset": 1,
    "endLine": 1947,
    "endOffset": 1
}

Response received: format (8). Request took 293 ms. Success: false . Message: Error processing request. Debug Failure. False expression: 

@dbaeumer
Copy link
Member

This issue was moved to microsoft/TypeScript#9668

@dbaeumer dbaeumer added typescript Typescript support issues upstream Issue identified as 'upstream' component related (exists outside of VS Code) labels Jul 13, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
typescript Typescript support issues upstream Issue identified as 'upstream' component related (exists outside of VS Code)
Projects
None yet
Development

No branches or pull requests

3 participants