Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong label for touch bar entry in Mac #80780

Closed
phammanh029 opened this issue Sep 12, 2019 · 6 comments · Fixed by microsoft/azuredatastudio#7206
Closed

Wrong label for touch bar entry in Mac #80780

phammanh029 opened this issue Sep 12, 2019 · 6 comments · Fixed by microsoft/azuredatastudio#7206
Assignees
@isidorn
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues verified Verification succeeded
Milestone
September 2019

Comments

@phammanh029
Copy link

  • VSCode Version: 1.39.0-insider
  • OS Version:Darwin x64 18.7.0
    i found on this line of code, it maybe miss match:
vscode/src/vs/workbench/contrib/debug/browser/debug.contribution.ts
registerTouchBarEntry(STEP_OVER_ID, STEP_OUT_LABEL, 2, CONTEXT_IN_DEBUG_MODE, URI.parse(registerAndGetAmdImageURL('vs/workbench/contrib/debug/browser/media/stepover-tb.png')));

i think it should be STEP_OVER_LABEL.

In debug mode on touchbar it show 2 entries with lablel Step out instead of Step Over and Step out
@vscodebot
Copy link

vscodebot bot commented Sep 12, 2019

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

@phammanh029 phammanh029 changed the title Wrong lable for touchbar entry in Mac Wrong label for touch bar entry in Mac Sep 12, 2019
@phammanh029
Copy link
Author

image

@isidorn
Copy link
Contributor

isidorn commented Sep 12, 2019

Good catch! Thanks for reporting this.

@isidorn isidorn added bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues labels Sep 12, 2019
@isidorn isidorn added this to the September 2019 milestone Sep 12, 2019
@anthonydresser anthonydresser mentioned this issue Sep 13, 2019
Merged
@sandy081
Copy link
Member

sandy081 commented Oct 3, 2019

I do not see labels in the Touch Bar and I see only icons. Is there a way to enable them?

@isidorn
Copy link
Contributor

isidorn commented Oct 3, 2019

No, you should see icons. So what you are seeing is expected.

@jrieken jrieken added the verified Verification succeeded label Oct 3, 2019
@jrieken
Copy link
Member

jrieken commented Oct 3, 2019

verified in code

@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@isidorn isidorn

Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues verified Verification succeeded
Projects
None yet
Milestone
September 2019
Development

Successfully merging a pull request may close this issue.

Merge from vscode 64980ea1f3f532c82bb6c28d27bba9ef2c5b4463 microsoft/azuredatastudio
4 participants
@jrieken @isidorn @phammanh029 @sandy081