Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better shortcuts for expand/shrink selection #80354

Closed
solomatov opened this issue Sep 5, 2019 · 5 comments
Closed

Better shortcuts for expand/shrink selection #80354

solomatov opened this issue Sep 5, 2019 · 5 comments
Assignees
Labels
feature-request Request for new features or functionality help wanted Issues identified as good community contribution opportunities macos Issues with VS Code on MAC/OS X smart-select verification-needed Verification of issue is requested verified Verification succeeded

Comments

@solomatov
Copy link
Contributor

Expand/shrink selection when aware of the code structure is a very useful shortcut. Unfortunately, on OSX, it's Ctrl+Shift+Cmd+Left/Right. It's very long, it's hard to press, and hard to remember.

It would be nice if it would be shorter by default. For example, Ctrl+Shift+Left/Right might be a much better option. Ideally it would be something short like Alt+Up/Down but it's already occupied.

P.S. I understand that I can set my own shortcuts. But there's a lot of value in a common keymap.

@octref octref assigned jrieken and unassigned octref Sep 5, 2019
@jrieken jrieken added feature-request Request for new features or functionality help wanted Issues identified as good community contribution opportunities smart-select labels Sep 6, 2019
@jrieken
Copy link
Member

jrieken commented Sep 6, 2019

Yeah, I am not a fan of the existing keybindings either. It's just a high density of existing keybindings and therefore hard to find alternatives. So, if you find a new set I am happily accepting a PR here.

@skprabhanjan
Copy link
Contributor

@solomatov , do you want to submit a PR or can I take this up ?
Also update what would be the replacement set if you want me to send a PR for this :)
IMHO : Ctrl+Shift+UpArrow/DownArrow is best ( there is no default shortcut for this I guess )

@solomatov
Copy link
Contributor Author

@jrieken Ok. I will. I will keep the old shortcut for a while since people with a better muscle memory than mine might got used to it :-)

@solomatov
Copy link
Contributor Author

I created a PR: #80491

I choose Ctrl+Shift+Left/Right since on other platforms Left/Right is used.

@jrieken jrieken added this to the September 2019 milestone Sep 6, 2019
@jrieken jrieken added the verification-needed Verification of issue is requested label Sep 6, 2019
@jrieken
Copy link
Member

jrieken commented Sep 6, 2019

👏 @solomatov

@jrieken jrieken closed this as completed Sep 6, 2019
@jrieken jrieken added the macos Issues with VS Code on MAC/OS X label Sep 30, 2019
@mjbvz mjbvz added the verified Verification succeeded label Oct 3, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality help wanted Issues identified as good community contribution opportunities macos Issues with VS Code on MAC/OS X smart-select verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

5 participants