Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce API to change DebugSession.name #80257

Closed
isidorn opened this issue Sep 3, 2019 · 1 comment
Closed

Introduce API to change DebugSession.name #80257

isidorn opened this issue Sep 3, 2019 · 1 comment
Assignees
Labels
api api-finalization api-proposal debug Debug viewlet, configurations, breakpoints, adapter issues

Comments

@isidorn
Copy link
Contributor

isidorn commented Sep 3, 2019

We would like to introduce API such that the Extensions can change the name of a DebugSession.
Our proposal is that we make the debugSession.name no longer readonly, but that it can be changed by extensions.

We also thought about constraining the name setter only to the extension which provides the debugger type for this DebugSession but we are not convinced this is needed.

Motivation for this: #79583
PR for hits: #80122

@isidorn isidorn added api debug Debug viewlet, configurations, breakpoints, adapter issues labels Sep 3, 2019
@isidorn isidorn added this to the September 2019 milestone Sep 3, 2019
@isidorn isidorn self-assigned this Sep 3, 2019
@isidorn
Copy link
Contributor Author

isidorn commented Sep 5, 2019

Tackled via #80122

@isidorn isidorn closed this as completed Sep 5, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api api-finalization api-proposal debug Debug viewlet, configurations, breakpoints, adapter issues
Projects
None yet
Development

No branches or pull requests

2 participants