Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hover / Suggest inconsistency: Plaintext Linkifying #79841

Closed
octref opened this issue Aug 26, 2019 · 3 comments
Closed

Hover / Suggest inconsistency: Plaintext Linkifying #79841

octref opened this issue Aug 26, 2019 · 3 comments
Assignees
Labels
editor-hover Editor mouse hover suggest IntelliSense, Auto Complete ux User experience issues
Milestone

Comments

@octref
Copy link
Contributor

octref commented Aug 26, 2019

Split from #78718:

Plaintext Linkifying

const markupContent: MarkupContent =  {
	kind: 'plaintext',
	value: 'https://code.visualstudio.com'
};

image

@octref octref added bug Issue identified by VS Code Team member as probable bug ux User experience issues suggest IntelliSense, Auto Complete editor-hover Editor mouse hover labels Aug 26, 2019
@octref octref added this to the September 2019 milestone Aug 26, 2019
@octref octref self-assigned this Aug 26, 2019
@octref
Copy link
Contributor Author

octref commented Sep 23, 2019

I think this should be done together with consideration for #79840. If for that we switch completion item details to use MarkdownString.appendText, this will be auto-fixed.

@octref octref modified the milestones: September 2019, October 2019 Sep 23, 2019
@octref
Copy link
Contributor Author

octref commented Sep 30, 2019

@jrieken Do you think we should linkify the links in plaintext by doing that in appendText?

@octref octref modified the milestones: October 2019, Backlog Oct 29, 2019
@jrieken jrieken assigned jrieken and unassigned octref May 6, 2020
@jrieken jrieken removed the bug Issue identified by VS Code Team member as probable bug label Oct 2, 2020
@jrieken
Copy link
Member

jrieken commented Oct 2, 2020

This works when using the correct type: vscode.MarkdownString. The type above (its name) doesn't exist, the structure (ignoring the name) is verbatim/code blocks

@jrieken jrieken closed this as completed Oct 2, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Dec 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
editor-hover Editor mouse hover suggest IntelliSense, Auto Complete ux User experience issues
Projects
None yet
Development

No branches or pull requests

2 participants