Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Grid: SCM input box does not extend its height for the placeholder text #79029

Closed
bpasero opened this issue Aug 13, 2019 · 2 comments · Fixed by microsoft/azuredatastudio#7206
Closed

Grid: SCM input box does not extend its height for the placeholder text #79029

bpasero opened this issue Aug 13, 2019 · 2 comments · Fixed by microsoft/azuredatastudio#7206
Assignees
@joaomoreno
Labels
bug Issue identified by VS Code Team member as probable bug scm General SCM compound issues verified Verification succeeded
Milestone
September 2019

Comments

@bpasero
Copy link
Member

bpasero commented Aug 13, 2019 •
edited by joaomoreno
Loading

When the input box is empty, there's a placeholder text. The inputbox should grow in size when the placeholder text wraps.

image
@bpasero bpasero added bug Issue identified by VS Code Team member as probable bug layout General VS Code workbench layout issues labels Aug 13, 2019
@sbatten
Copy link
Member

sbatten commented Aug 13, 2019

no difference between grid and legacy layout for me

@sbatten sbatten removed their assignment Aug 13, 2019
@sbatten sbatten added the scm General SCM compound issues label Aug 13, 2019
@joaomoreno
Copy link
Member

joaomoreno commented Aug 30, 2019 •
edited
Loading

@bpasero This is just the placeholder text. If you type something in the box, it wraps.

Started happening since the PR to get our custom scrollbar in the input.

@joaomoreno joaomoreno changed the title Grid: SCM input box does not wrap Grid: SCM input box does not wrap when it's emtpy Aug 30, 2019
@joaomoreno joaomoreno changed the title Grid: SCM input box does not wrap when it's emtpy Grid: SCM input box does not wrap when it's empty Aug 30, 2019
@joaomoreno joaomoreno added this to the September 2019 milestone Aug 30, 2019
@joaomoreno joaomoreno changed the title Grid: SCM input box does not wrap when it's empty Grid: SCM input box does not extend its height for the placeholder text Aug 30, 2019
@joaomoreno joaomoreno removed the layout General VS Code workbench layout issues label Aug 30, 2019
@joaomoreno joaomoreno mentioned this issue Sep 5, 2019
Closed
@anthonydresser anthonydresser mentioned this issue Sep 13, 2019
Merged
@bpasero bpasero added the verified Verification succeeded label Oct 1, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@joaomoreno joaomoreno

Labels
bug Issue identified by VS Code Team member as probable bug scm General SCM compound issues verified Verification succeeded
Projects
None yet
Milestone
September 2019
Development

Successfully merging a pull request may close this issue.

Merge from vscode 64980ea1f3f532c82bb6c28d27bba9ef2c5b4463 microsoft/azuredatastudio
3 participants
@joaomoreno @bpasero @sbatten