Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimap search decorations are hard to see #76122

Closed
miguelsolorio opened this issue Jun 25, 2019 · 6 comments
Closed

Minimap search decorations are hard to see #76122

miguelsolorio opened this issue Jun 25, 2019 · 6 comments
Assignees
Labels
editor-minimap Code/Text minimap widget issues on-testplan
Milestone

Comments

@miguelsolorio
Copy link
Contributor

Testing #76030

image

I get that you're using the same color as the highlighted text in the editor, but this is hard to see even if you're looking for it. I wonder if it's worth exploring to try a different color in our default themes?

@usernamehw
Copy link
Contributor

Minimap appears to be too small for decorations. Maybe you can consider making an option to scale it for the next iteration? #21773

@usernamehw
Copy link
Contributor

Highlighting the entire line could also help #21404 (comment)

@stiegi
Copy link

stiegi commented Jul 6, 2019

No, it should be just like in Sublime or Atom: a bright, white rectangle around the result. It should also be there after doubleclicking something, and NOT the complete line, because this feature is supposed to help finding the horizontal position, too.

@usernamehw
Copy link
Contributor

usernamehw commented Jul 6, 2019

Line highlighting could be half/more than half transparent so that it would be easy to find the line and the precise horizontal location (like diff):

Screenshot (18)

@RMacfarlane
Copy link
Contributor

I like the idea of highlighting the whole line. Here’s what that looks like in a prototype:
Screen Shot 2019-07-10 at 2 30 15 PM

I defined a new theme color, minimap.findMatchHighlight, which by default is the same as the overview ruler but opaque. As @usernamehw suggested, I added a line highlight that’s half transparent.

I’ll check this in for now, still happy to take more feedback and experiment more over the iteration.

@RMacfarlane RMacfarlane added the editor-minimap Code/Text minimap widget issues label Jul 10, 2019
@RMacfarlane RMacfarlane added this to the July 2019 milestone Jul 10, 2019
@RMacfarlane
Copy link
Contributor

Closing this since I’m happy with the decorations now in insiders and haven’t had more feedback. Thanks all!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
editor-minimap Code/Text minimap widget issues on-testplan
Projects
None yet
Development

No branches or pull requests

4 participants