Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use os context keys instead of if statements in menubar action registration #56274

Closed
sbatten opened this issue Aug 13, 2018 · 0 comments
Closed

Use os context keys instead of if statements in menubar action registration #56274

sbatten opened this issue Aug 13, 2018 · 0 comments
Assignees
@sbatten
Labels
debt Code quality issues
Milestone
September 2018

Comments

@sbatten
Copy link
Member

sbatten commented Aug 13, 2018

OS-Specific context keys were added with #54894 We should use them in menu registration instead of if clauses.
@sbatten sbatten added the debt Code quality issues label Aug 13, 2018
@sbatten sbatten added this to the On Deck milestone Aug 13, 2018
@sbatten sbatten self-assigned this Aug 13, 2018
@sbatten sbatten mentioned this issue Aug 13, 2018
Merged
@sbatten sbatten modified the milestones: On Deck, September 2018 Sep 7, 2018
@sbatten sbatten closed this as completed in f34d169 Sep 7, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 22, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sbatten sbatten

Labels
debt Code quality issues
Projects
None yet
Milestone
September 2018
Development

No branches or pull requests
1 participant
@sbatten