Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove references to specific menu entries from menubar.ts #55149

Closed
isidorn opened this issue Jul 26, 2018 · 2 comments
Closed

Remove references to specific menu entries from menubar.ts #55149

isidorn opened this issue Jul 26, 2018 · 2 comments
Assignees
@sbatten
Labels
debt Code quality issues
Milestone
On Deck

Comments

@isidorn
Copy link
Contributor

isidorn commented Jul 26, 2018

As discussed in #54826
I believe all references to specific menu entries should be removed from menubar.ts
These menu entries should somehow be registered from their respective areas. 'debug' from debug.contribution.ts and so on.
@isidorn isidorn added debt Code quality issues workbench-menu labels Jul 26, 2018
@sbatten sbatten added this to the On Deck milestone Aug 8, 2018
@bpasero
Copy link
Member

bpasero commented May 26, 2019

I think this can probably be closed by now, at least I cannot find specific debug entries anymore.

@isidorn
Copy link
Contributor Author

isidorn commented May 27, 2019

Yes this looks better now, closing

@isidorn isidorn closed this as completed May 27, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Jul 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sbatten sbatten

Labels
debt Code quality issues
Projects
None yet
Milestone
On Deck
Development

No branches or pull requests
3 participants
@bpasero @isidorn @sbatten