Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce "search.include" (NOT A DUPLICATE) #242051

Open
umarbutler opened this issue Feb 26, 2025 · 1 comment
Open

Introduce "search.include" (NOT A DUPLICATE) #242051

umarbutler opened this issue Feb 26, 2025 · 1 comment
Assignees

Comments

@umarbutler
Copy link

umarbutler commented Feb 26, 2025

I am a data scientist. I have a blanket user-level **/*.json exclusion. That works great for me because typically I treat JSON files as data files.

Sometimes, I may be working on a web project where actually most JSON files are config files.

Then it becomes really useful to be able to include JSON files in my searches.

And yet, there is no "search.include" setting that would allow me to do that.

Instead, I am forced to either:

  • Accept that I cannot search JSON files.
  • Remove my user-level "**/*.json" exclude and then for all my Python projects, readd it at the workspace level.

I would like to request the introduction of a "search.include" setting.

This is not a duplicate of #869 and I would kindly request that this does not be closed like what happened to #203063.

In #203063, @andreamah wrote "Although your use case is different, the implications and implementation of a search.include should also consider the use cases that others have for creating more advanced file/search globbing" -- her comment very clearly notes that the "use case is different". The request itself is different as #869 is focused on making "files.exclude" more advanced.

What I am saying though is that even if you made file.exclude more advanced, how are you going to override parent-defined exclusions?

That is why "search.include" is necessary.

@gjsjohnmurray
Copy link
Contributor

Did you try using a separate profile for your web projects?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants