Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attachment file name overflow lacks ... and is unusual #241838

Closed
alexdima opened this issue Feb 25, 2025 · 2 comments · Fixed by #241990
Closed

Attachment file name overflow lacks ... and is unusual #241838

alexdima opened this issue Feb 25, 2025 · 2 comments · Fixed by #241990
Assignees
@justschen
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders
Milestone
February 2025

Comments

@alexdima
Copy link
Member

alexdima commented Feb 25, 2025 •
edited
Loading

Testing #241777

Note the overflow behavior. This is quite different from other file name overflows, like in the Explorer

CleanShot.2025-02-25.at.11.33.36.mp4
CleanShot.2025-02-25.at.11.35.28.mp4
@justschen justschen mentioned this issue Feb 26, 2025
Merged
@vs-code-engineering vs-code-engineering bot added the unreleased Patch has not yet been released in VS Code Insiders label Feb 26, 2025
@vs-code-engineering vs-code-engineering bot added this to the February 2025 milestone Feb 26, 2025
@justschen justschen added the bug Issue identified by VS Code Team member as probable bug label Feb 26, 2025
@justschen justschen mentioned this issue Feb 26, 2025
Closed
@vs-code-engineering vs-code-engineering bot added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Feb 26, 2025
@aiday-mar
Copy link
Contributor

Hi just tested this, I see that the pill text disappears in a smooth manner but there is no ellipsis. Is there supposed to be an ellipsis in the text when it is truncated?

Screen.Recording.2025-02-26.at.18.07.42.mov

@justschen justschen mentioned this issue Feb 26, 2025
Merged
@justschen
Copy link
Contributor

should be fixed for all attachments on next insiders 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@justschen justschen

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders
Projects
None yet
Milestone
February 2025
Development

Successfully merging a pull request may close this issue.

fix custom attachment overflow justschen/vscode
3 participants
@alexdima @justschen @aiday-mar