Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit, Copy, Remove, Reset options in a single menu for keybindings #23496

Closed
ramya-rao-a opened this issue Mar 28, 2017 · 2 comments
Closed

Edit, Copy, Remove, Reset options in a single menu for keybindings #23496

ramya-rao-a opened this issue Mar 28, 2017 · 2 comments
Assignees
Labels
*as-designed Described behavior is as designed feature-request Request for new features or functionality keybindings VS Code keybinding issues
Milestone

Comments

@ramya-rao-a
Copy link
Contributor

Testing #23287

In the settings editor, the "edit" icon gives options like "Copy" and in case of enum or boolean, gives you options for the same.

Why not use the same approach for keybindings and combine Edit, Copy, Remove, Reset options in a single menu?

The right-click to copy, remove, reset is not discoverable

@ramya-rao-a ramya-rao-a added the keybindings VS Code keybinding issues label Mar 28, 2017
@sandy081 sandy081 added the feature-request Request for new features or functionality label Mar 29, 2017
@sandy081 sandy081 added this to the Backlog milestone Mar 29, 2017
@sandy081
Copy link
Member

Good suggestion. In Settings editor we do not want to have two clicks to change/add a new keybinding. I think we need two actions in the left

  • One edit/add action
  • Two a small dropdown to show other actions

@sandy081 sandy081 added the *as-designed Described behavior is as designed label Nov 27, 2017
@sandy081
Copy link
Member

Another reasoning, why not having all actions on edit icon is that, most commonly used action is to change the keybinding. If we overload edit icon with more actions, then user has to click twice to change keybinding which is not good experience to user. I think current approach of edit icon changes the keybinding and context menu actions for secondary actions is consistent with our over all UI.

@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 11, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*as-designed Described behavior is as designed feature-request Request for new features or functionality keybindings VS Code keybinding issues
Projects
None yet
Development

No branches or pull requests

2 participants