Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiple edit icons in keybindings editor #23492

Closed
ramya-rao-a opened this issue Mar 28, 2017 · 2 comments
Closed

Multiple edit icons in keybindings editor #23492

ramya-rao-a opened this issue Mar 28, 2017 · 2 comments
Assignees
@sandy081
Labels
bug Issue identified by VS Code Team member as probable bug keybindings VS Code keybinding issues *out-of-scope Posted issue is not in scope of VS Code
Milestone
Backlog

Comments

@ramya-rao-a
Copy link
Contributor

Testing #23287

image

You can reach this state by

  1. Click on any shortcut
  2. Right Click on any other shortcut
  3. This opens the menu, press esc
  4. Hover around any other shortcut
@sandy081 sandy081 added the keybindings VS Code keybinding issues label Mar 29, 2017
@sandy081 sandy081 added this to the March 2017 milestone Mar 29, 2017
@sandy081
Copy link
Member

sandy081 commented Mar 29, 2017 •
edited
Loading

Partly Fixed by b63cd54

With this fix the above scenario shows two edit icons - one for selection and one for hover.
But there is still possibility to see 3 edit icons - one for selection, one for focus, one for hover.

To fix it completely - Show the edit icon always which is also good for discoverability but not a better UI. Have to put more thinking.

@sandy081 sandy081 modified the milestones: April 2017, March 2017 Mar 29, 2017
@sandy081 sandy081 modified the milestones: Backlog, April 2017 Apr 5, 2017
@sandy081 sandy081 added the bug Issue identified by VS Code Team member as probable bug label Apr 7, 2017
@sandy081 sandy081 added the *out-of-scope Posted issue is not in scope of VS Code label Nov 27, 2017
@vscodebot
Copy link

vscodebot bot commented Nov 27, 2017

This feature request will not be considered in the next 6-12 months roadmap and has been closed to keep the number of issues we have to maintain manageable. See also our issue reporting guidelines.

Thanks for your understanding and happy coding!

@vscodebot vscodebot bot closed this as completed Nov 27, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 11, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sandy081 sandy081

Labels
bug Issue identified by VS Code Team member as probable bug keybindings VS Code keybinding issues *out-of-scope Posted issue is not in scope of VS Code
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
2 participants
@sandy081 @ramya-rao-a