Empty tree should not be focusable

[alexdima]

Testing #2145

e.g. debug variables tree

[bpasero]

@alexandrudima an empty tree can still have a context menu associated. are you saying we should detect the case where the tree is empty && has no context menu? I am not sure this would confuse people why sometimes they see blue and sometimes they do not.

[alexdima]

Good point about the context menu case, so maybe it makes sense to tab into an empty explorer tree given that's the only place where a context menu can be invoked.

IMHO in this case, tabbing into an empty variable list in the debugger is pretty useless.

[bpasero]

@alexandrudima but that is up to the tree right? e.g. I can also tab into watch expressions to create a new one there.

[alexdima]

Right clicking in empty spaces appears to be common:

• e.g. in this webpage I can right click on the whitespace
• e.g. on my desktop I can right click anywhere on it
• however, the whitespace on this webpage is not "focusable" and there must be alternative ways to get those actions besides context menu...

[bpasero]

@alexandrudima sorry can you clarify what your last comment means?

[alexdima]

gif time :)

I can do a contextmenu with the mouse in areas where I cannot go to via tab focus. e.g. the whitespace on this webpage or the desktop. I only assume there must be alternative ways to trigger those actions since I cannot get to focus the whitespace to trigger a contextmenu with the keyboard

[bpasero]

Well yeah, might be. All I am saying is that imho it makes sense to draw the blue border in the tree as long as you can trigger the context menu (using the context menu key on the keyboard). Even if there are other ways I find this a nice gesture.

[bpasero]

We should take this to UX meeting.

[stevencl]

Even if there is no context menu available for a focusable UI panel I think we should still allow the user to tab into it to set focus. This lets them know and discover the different UI panels and components. For example, a screen reader might read out something about the empty panel.

[bpasero]

Yeah, also a good point. In fact every tree has a meaningful aria label assigned now.

[bpasero]

Closing.