Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit button is permanently shown #23364

Closed
alexdima opened this issue Mar 28, 2017 · 3 comments
Closed

Edit button is permanently shown #23364

alexdima opened this issue Mar 28, 2017 · 3 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug keybindings VS Code keybinding issues verified Verification succeeded
Milestone

Comments

@alexdima
Copy link
Member

alexdima commented Mar 28, 2017

Testing #23287

I clicked edit a couple of times, and now I am in a state where the text is white on whites and the edit button is shown. I also switched keyboard layouts.

I think somehow the list thinks the selection is on that row:

image

This funny state recovers once I click on a different row.

@sandy081 sandy081 added bug Issue identified by VS Code Team member as probable bug keybindings VS Code keybinding issues labels Mar 28, 2017
@sandy081 sandy081 added this to the March 2017 milestone Mar 28, 2017
@sandy081
Copy link
Member

Assigned to March for initial investigation

@sandy081
Copy link
Member

Steps to reproduce this:

  1. Open new keybindings editor
  2. Click down arrow from Search input -> Focuses the first element in the list
  3. Press Enter to select the first element
  4. Press down arrow to focus the second element
  5. Press Enter to select the second element
  6. Press Up arrow to focus the first element
    -> Second element will go to bad state: White on whites and edit button is shown.

@sandy081
Copy link
Member

Fixed by e13a915

@michelkaporin michelkaporin added the verified Verification succeeded label Mar 30, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug keybindings VS Code keybinding issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants