Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undo stacks are not granular enough for Korean #229647

Open
Tyriar opened this issue Sep 25, 2024 · 3 comments
Open

Undo stacks are not granular enough for Korean #229647

Tyriar opened this issue Sep 25, 2024 · 3 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug editor-input-IME Editor input of characters not on keyboard undo-redo Issues around undo/redo

Comments

@Tyriar
Copy link
Member

Tyriar commented Sep 25, 2024

Testing #229383

Right now, typing a sentence in Korean and pressing undo will remove the entire line. I confirmed with a native Korean speaker that the ideal behavior for undo is to remove the last consonant/vowel (each character is made up of 2-4 consonants/vowels). This might be difficult to do depending on how EditContext words, but a little less better but much better than deleting the whole line is to delete the last fully formed character.

Image

Note that this is not a regression, but it's a pretty bad existing great experience.

@anthonykim1
Copy link
Contributor

anthonykim1 commented Sep 25, 2024

I second this, there are many devs in Korea (and their tutorials) use and stick with VS Code as their editor.

From several popular tutorials I've seen there are many folks who would write code in English, but would write comment in Korean.
It feels pretty frustrating and sad to have your entire line get thrown away with one undo :/

Many folks would greatly appreciate and be happier with better support for this.

@Tyriar
Copy link
Member Author

Tyriar commented Sep 25, 2024

Strangely this seems to diff per platform? Undo deletes the line on macOS and the word on Windows

@aiday-mar
Copy link
Contributor

aiday-mar commented Sep 25, 2024

I see thanks for letting me know. It would seem the current implementation using the text area also has this issue. I will investigate how we can improve this.

There is another related issue here : #229606, where sometimes after you type ni hao and select the Chinese word and then press undo, this undoes the word to ni hao and sometimes it undoes it to an empty string. This seems to happen both with and without the setting.

@aiday-mar aiday-mar added bug Issue identified by VS Code Team member as probable bug undo-redo Issues around undo/redo editor-edit-context labels Sep 25, 2024
@aiday-mar aiday-mar added editor-input-IME Editor input of characters not on keyboard and removed editor-edit-context labels Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug editor-input-IME Editor input of characters not on keyboard undo-redo Issues around undo/redo
Projects
None yet
Development

No branches or pull requests

4 participants