Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Few Small issues regarding the Menu Bar after recent updates to enable Top positioning option #211353

Closed
RadhiRasho opened this issue Apr 25, 2024 · 2 comments · Fixed by #213463
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders layout General VS Code workbench layout issues verified Verification succeeded
Milestone

Comments

@RadhiRasho
Copy link

Does this issue occur when all extensions are disabled?: Yes

  • VS Code Version: Version: 1.88.1
  • OS Version: Windows 10 Enterprise 22H2

Steps to Reproduce:

  1. Set Activity Bar to Top
  2. Set Menu Bar to hidden
  3. Set Side Bar to location to right
  4. Click Alt which should switch to the Menu Bar (Hamburger menu) in the Activity Bar don't do so now, possibly due to the switching of the position of Activity Bar to Top
  5. Click the Menu Bar item and you'll see that the context menu opened is misaligned with the current position of the Menu Bar, this doesn't seem to be an issue when the Side Bar location is to the left only on the right.

Image:
image

@benibenj benibenj self-assigned this Apr 25, 2024
@benibenj benibenj added layout General VS Code workbench layout issues bug Issue identified by VS Code Team member as probable bug labels Apr 25, 2024
@Lyqst
Copy link

Lyqst commented May 24, 2024

Hello! This has been bugging me for a while now (I use the sidebar to the right and the activity bar on top), so I decided to go ahead and try and fix this.

I realized the underlying issue is that when the Side Bar is to the left and you hide the Menu Bar, the hamburger button is placed to the left regardless of the position of the Activity Bar, but when the Side Bar is to the right, its inconsistent (top right when both bars are to the right, but not when Side Bar is right and Activity Bar is top), so my proposed fix is to move the hamburger button to the far right in the latter case, so its position is more consistent.

Sidebar right and activity bar default

image image

Sidebar right and activity bar top

image image

Let me know what you think and I'll create the PR.

@benibenj
Copy link
Contributor

I fixed to position of the menu bar when the side bar is to the right.
I check regarding alt moving focus to the compact menu and saw it does work, but we just don't show any indication that focus is there. Which we need to fix

@benibenj benibenj added this to the May 2024 milestone May 25, 2024
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels May 25, 2024
@rzhao271 rzhao271 added the verified Verification succeeded label May 29, 2024
@microsoft microsoft locked and limited conversation to collaborators Jul 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders layout General VS Code workbench layout issues verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants