Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Screen 🧀 on empty commits #199311

Closed
joaomoreno opened this issue Nov 28, 2023 · 1 comment · Fixed by #199438
Closed

Screen 🧀 on empty commits #199311

joaomoreno opened this issue Nov 28, 2023 · 1 comment · Fixed by #199438
Assignees
@lszomoru
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders scm General SCM compound issues verified Verification succeeded
Milestone
November 2023

Comments

@joaomoreno
Copy link
Member

Testing #199177

  1. Run git commit --allow-empty -m foo
  2. Reveal the commit in the outgoing section

🐛 Notice the empty square in All Changes

image
@joaomoreno joaomoreno mentioned this issue Nov 28, 2023
Closed
@lszomoru lszomoru added bug Issue identified by VS Code Team member as probable bug scm General SCM compound issues labels Nov 28, 2023
@lszomoru lszomoru added this to the November 2023 milestone Nov 28, 2023
@lszomoru lszomoru mentioned this issue Nov 28, 2023
Merged
@lszomoru
Copy link
Member

Diff statistics badge will always contain the number of files:
image

@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Nov 28, 2023
@joyceerhl joyceerhl added the verified Verification succeeded label Nov 30, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jan 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@lszomoru lszomoru

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders scm General SCM compound issues verified Verification succeeded
Projects
None yet
Milestone
November 2023
Development

Successfully merging a pull request may close this issue.

SCM - handle empty commit in diff statistics badge microsoft/vscode
4 participants
@joaomoreno @lszomoru @joyceerhl @vscodenpa