Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[regression] CodeAction on save is broken #194397

Closed
jrieken opened this issue Sep 28, 2023 · 2 comments · Fixed by #194409
Closed

[regression] CodeAction on save is broken #194397

jrieken opened this issue Sep 28, 2023 · 2 comments · Fixed by #194409
Assignees
@mjbvz @justschen
Labels
bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority verified Verification succeeded
Milestone
September 2023

Comments

@jrieken
Copy link
Member

jrieken commented Sep 28, 2023 •
edited
Loading

Version: 1.83.0-insider
Commit: aad333b

  • have the user setting spec'd below
  • open src/vs/editor/contrib/stickyScroll/test/browser/stickyScroll.test.ts
  • remove the semicolon on line 29
  • save via Cmd+S, semi column isn't inserted
  "editor.codeActionsOnSave": {
    "source.fixAll.eslint": "explicit",
    "source.removeUnusedImports": "explicit"
  },
@jrieken jrieken added the important Issue identified as high-priority label Sep 28, 2023
@jrieken jrieken added this to the September 2023 milestone Sep 28, 2023
@jrieken
Copy link
Member Author

jrieken commented Sep 28, 2023

cc @dbaeumer

@justschen justschen mentioned this issue Sep 28, 2023
Merged
@vscodenpa vscodenpa added the unreleased Patch has not yet been released in VS Code Insiders label Sep 28, 2023
@bhavyaus bhavyaus added bug Issue identified by VS Code Team member as probable bug and removed unreleased Patch has not yet been released in VS Code Insiders labels Sep 28, 2023
@bhavyaus
Copy link
Collaborator

bhavyaus commented Sep 28, 2023 •
edited
Loading

Issue tracking verification of this fix is in #194437

@justschen justschen mentioned this issue Sep 28, 2023
Closed
@chrmarti chrmarti added the verified Verification succeeded label Sep 29, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Nov 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mjbvz mjbvz

@justschen justschen

Labels
bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority verified Verification succeeded
Projects
None yet
Milestone
September 2023
Development

Successfully merging a pull request may close this issue.

Removed default settings for Code Actions on Save justschen/vscode
6 participants
@jrieken @chrmarti @mjbvz @bhavyaus @justschen @vscodenpa