Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Every keyboard action with the 'modified elsewhere' pop-up open will close the pop-up and lose focus #167570

Closed
amunger opened this issue Nov 29, 2022 · 2 comments
Assignees
Labels
info-needed Issue requires more information from poster verified Verification succeeded

Comments

@amunger
Copy link
Contributor

amunger commented Nov 29, 2022

Testing #167088

  1. open the settings tab
  2. tab to a "modified elsewhere" tag
  3. press enter to open the pop-up
  4. press enter, esc, tab or down arrow
    result: pop-up closes and focus goes somewhere else (don't know where)

expected:
to be able to navigate to the link in the pop-up
if I press escape, focus should return to the tag

@rzhao271
Copy link
Contributor

Does this behaviour occur on the latest Insiders? I merged in some changes recently, so you might be seeing the old behaviour.

@rzhao271 rzhao271 added the info-needed Issue requires more information from poster label Nov 29, 2022
@amunger
Copy link
Contributor Author

amunger commented Nov 29, 2022

no, I hadn't updated yet. works as expected

@amunger amunger closed this as completed Nov 29, 2022
@amunger amunger added the verified Verification succeeded label Nov 29, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jan 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
info-needed Issue requires more information from poster verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

2 participants