Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the ability to hide numbered badges on views #167434

Closed
lramos15 opened this issue Nov 28, 2022 · 4 comments
Closed

Add the ability to hide numbered badges on views #167434

lramos15 opened this issue Nov 28, 2022 · 4 comments
Assignees
@lramos15
Labels
feature-request Request for new features or functionality on-release-notes Issue/pull request mentioned in release notes on-testplan workbench-notifications Notification widget issues
Milestone
November 2022

Comments

@lramos15
Copy link
Member

With the addition of the badges API, badges on arbitrary view containers continue to become more common. We don't want to add settings for every view, so this should be state that is easy to set on a per view basis.
@lramos15 lramos15 added feature-request Request for new features or functionality workbench-notifications Notification widget issues labels Nov 28, 2022
@lramos15 lramos15 added this to the November 2022 milestone Nov 28, 2022
@lramos15 lramos15 self-assigned this Nov 28, 2022
@lramos15
Copy link
Member Author

lramos15 commented Nov 28, 2022 •
edited
Loading

First run for feedback fixed via #158781

@lramos15 lramos15 mentioned this issue Nov 28, 2022
Closed
2 tasks
@lramos15 lramos15 added the on-release-notes Issue/pull request mentioned in release notes label Dec 2, 2022
@aslatter
Copy link

aslatter commented Dec 11, 2022 •
edited
Loading

When I right-click on the source-control-icon and hide the numbered-badge, if I close VS Code and re-open it the numbered-badge is back.

Is that expected?

@lramos15
Copy link
Member Author

When I right-click on the source-control-icon and hide the numbered-badge, if I close VS Code and re-open it the numbered-badge is back.

Is that expected?

Feel free to file an issue to track that. It doesn't currently save state and these are definitely improvements we can make.

@aslatter
Copy link

Feel free to file an issue to track that. It doesn't currently save state and these are definitely improvements we can make.

Written in #168939

Thanks for the feature!

@github-actions github-actions bot locked and limited conversation to collaborators Jan 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@lramos15 lramos15

Labels
feature-request Request for new features or functionality on-release-notes Issue/pull request mentioned in release notes on-testplan workbench-notifications Notification widget issues
Projects
None yet
Milestone
November 2022
Development

No branches or pull requests
3 participants
@aslatter @lramos15 @vscodenpa