Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webview HTML5 video elements should allow full-screen mode #165073

Closed
matthewjamesadam opened this issue Oct 31, 2022 · 4 comments
Closed

Webview HTML5 video elements should allow full-screen mode #165073

matthewjamesadam opened this issue Oct 31, 2022 · 4 comments
Assignees
Labels
feature-request Request for new features or functionality webview Webview issues

Comments

@matthewjamesadam
Copy link
Contributor

Does this issue occur when all extensions are disabled?: No, this will happen for any extension webviews using video elements

  • VS Code Version: 1.72.2
  • OS Version: MacOS 12.5.1

Any extension showing a webview that contains an HTML5 video element will display with full-screen disabled. The screenshot below shows a webview with a video element, note that the full screen button is disabled:

CleanShot 2022-10-31 at 10 56 52@2x

In our case, our videos can be quite large, with lots of detail. It is appropriate to show this inline at first, but it is important for our users to be able to view the video full-screen to see the extra detail, as well.

Thanks!

@matthewjamesadam
Copy link
Contributor Author

This might be the same root issue as #110766, I am not certain.

@mjbvz mjbvz added the feature-request Request for new features or functionality label Nov 2, 2022
@vscodenpa vscodenpa added this to the Backlog Candidates milestone Nov 2, 2022
@vscodenpa
Copy link

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

@mjbvz mjbvz added the webview Webview issues label Dec 5, 2022
@vscodenpa
Copy link

This feature request has not yet received the 20 community upvotes it takes to make to our backlog. 10 days to go. To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

@vscodenpa
Copy link

🙁 In the last 60 days, this feature request has received less than 20 community upvotes and we closed it. Still a big Thank You to you for taking the time to create this issue! To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

@vscodenpa vscodenpa closed this as not planned Won't fix, can't repro, duplicate, stale Jan 2, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Feb 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality webview Webview issues
Projects
None yet
Development

No branches or pull requests

3 participants