Save errors should show a modal dialog when explicitly saving

[nonopolarity]

Does this issue occur when all extensions are disabled?: Yes/No

Yes

• VS Code Version: 1.67.1
• OS Version: macOS 12.0.1

Steps to Reproduce:

1. open the file try.txt, and add a line new line HELLO
2. either use any automatic method, or use emacs, vim, and edit that file try.txt by adding a line HI HI and save it.
3. Now go back to VSC and save that file. A VERY SUBTLE: it will overwrite the file. Do you want to overwrite or not? message appear. 9 times out of 10, I cannot catch that box, because it is way too subtle. If may even appear to be "We have a survey. Do you want to participate?" If it is a simple file like this, the warning may be more apparent, but if the file is like a complicated, 2000 lines long JSON file or XML file, the box appeared a lot less obvious. Many times, I just thought it is saved and went away, only to find out hours later that it wasn't saved.

How to fix: There are some warnings that are way more important than a subtle hint. Make it prominent so the user cannot miss.

The user asked to save and it did not save and it belongs to the warning that pops up right in the center of the window.

[vscodenpa]

Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.67.2. Please try upgrading to the latest version and checking whether this issue remains.

Happy Coding!

[bpasero]

Yeah agreed, maybe it should be modal if the save action is explicit.

[vscodenpa]

We closed this issue because we don't plan to address it in the foreseeable future. If you disagree and feel that this issue is crucial: we are happy to listen and to reconsider.

If you wonder what we are up to, please see our roadmap and issue reporting guidelines.

Thanks for your understanding, and happy coding!