Voiceover when expanding selection could be better

[JacksonKearl]

Couple issues:

1. when expanding the ***** selection, it only ever says 1star star star` selected even when more *'s are shown in the text. This seems to be a macos global bug
2. The formatting foo unselected, foo bar selected is not great, it hides the most important info. This seems to be a chromium thing, repros in edge, but notes handles it better IMO

[isidorn]

@JacksonKearl can you reproduce with VoiceOver and textArea here https://developer.mozilla.org/en-US/docs/Web/HTML/Element/textarea
If yes, can you please file a new issue for VoiceOver here https://bugs.webkit.org/
Then I can share the bug with the VoiceOver authors. Thanks!

[JacksonKearl]

It works fine in WebKit, seems to be only Chromium/Electron that's effected.

[isidorn]

@JacksonKearl if you can reproduce with Chromium then can you file a new issue in https://bugs.chromium.org/p/chromium/issues/list

Or are you saying you can only reproduce with Electron?

[JacksonKearl]

Sure, reported here https://bugs.chromium.org/p/chromium/issues/detail?id=1313990 👍

[MarcoZehe]

Is #162152 a duplicate of this bug?

[JacksonKearl]

@MarcoZehe yes I believe so, good news is chromium fixed this 12 days ago! https://bugs.chromium.org/p/chromium/issues/detail?id=1172956#c7

Bad news is it may be a while before vscode gets that build.

[MarcoZehe]

Thanks! Yes, I saw that it is fixed now, and I also discovered that I was the one who originally filed this bug report in February 2021. I couldn't figure out what version of Chromium this will be in, though, but I suppose it is currently in Canary and has to move through beta and release for the next couple of weeks, then to Electron, until it finally hits VSCode once it moves to that version of Electron that has the fix.

[isidorn]

@MarcoZehe thanks for opening the original issue on the Chromium side.
@deepak1556 can we back port the chromium fix so it is included as part of our next Electron update?
@meganrogge fyi

@JacksonKearl hey there 👋

[deepak1556]

Fixed upstream issue: https://bugs.chromium.org/p/chromium/issues/detail?id=1172956

I will backport the fix with Electron 22 update.

[deepak1556]

Reopening because Electron 22 was reverted for the March milestone.

[alexr00]

I can't reproduce the original issue in stable. I don't get the "__ unselected" when expanding the selection. Is this a macOS specific bug?

[MarcoZehe]

Yes, this is Mac specific.

…

Message ID: ***@***.***>